Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at_c: use atclient_connection_read in atclient_get_atkeys #354

Open
JeremyTubongbanua opened this issue Jul 30, 2024 · 1 comment
Open
Assignees

Comments

@JeremyTubongbanua
Copy link
Member

Currently, we have a fixed read buffer of 4096 bytes. If scan outputs a larger output of 4096 bytes, then not all keys will be captured in the read.

Therefore, we should use the new atclient_connection_read implementation where a maximum buffer size can be specified through atclient_get_atkeys_request_options

@JeremyTubongbanua JeremyTubongbanua self-assigned this Jul 30, 2024
@JeremyTubongbanua
Copy link
Member Author

Making this P2 because atclient_get_atkeys currently won't work for large scans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant