Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at_c: use Unity as our unit testing framework #356

Open
6 tasks
JeremyTubongbanua opened this issue Jul 30, 2024 · 0 comments
Open
6 tasks

at_c: use Unity as our unit testing framework #356

JeremyTubongbanua opened this issue Jul 30, 2024 · 0 comments
Assignees

Comments

@JeremyTubongbanua
Copy link
Member

JeremyTubongbanua commented Jul 30, 2024

Right now in our unit tests, we simply do if-statement checks to check if a value is as expected.

It was discussed in #344 that we should make our own atassert library and even use it in our arguments validation in every function, but I think it is okay to just use another assertion library such as Unity and even make use of its features like mocks. As for arguments validation, if-statements are fine, since there aren't many of them.

Work involved:

  • Create find_unity.cmake in ./cmake/
  • Add Unity as part of our CMakeLists.txt
  • Use assertion library in atchops unit tests
  • Rename atchops tests accordingly to previous refactors and conventions
  • Use assertion library in atclient unit tests
  • Rename atclient tests accordingly to previous refactors and conventions
@JeremyTubongbanua JeremyTubongbanua changed the title at_c: Use Unity as our unit testing framework at_c: use Unity as our unit testing framework Jul 30, 2024
@JeremyTubongbanua JeremyTubongbanua self-assigned this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant