From b96cde5656c904ccd5a2051d9c294ad521fe5c9f Mon Sep 17 00:00:00 2001
From: XavierChanth <xchanthavong@gmail.com>
Date: Tue, 10 Dec 2024 17:03:33 -0500
Subject: [PATCH] chore: cleanup some tests

---
 packages/atclient/tests/CMakeLists.txt           | 16 ++++++++--------
 .../{atclient => atcommons}/tests/test_cjson.c   |  2 +-
 .../tests/test_atclient_notify.c                 | 10 +++++-----
 3 files changed, 14 insertions(+), 14 deletions(-)
 rename packages/{atclient => atcommons}/tests/test_cjson.c (96%)

diff --git a/packages/atclient/tests/CMakeLists.txt b/packages/atclient/tests/CMakeLists.txt
index 6bfc370c..d335d259 100644
--- a/packages/atclient/tests/CMakeLists.txt
+++ b/packages/atclient/tests/CMakeLists.txt
@@ -1,11 +1,11 @@
-
 file(GLOB_RECURSE files ${CMAKE_CURRENT_LIST_DIR}/test_*.c)
 foreach(file ${files})
-    # ${filename} - without `.c`
-    get_filename_component(filename ${file} NAME)
-    string(REPLACE ".c" "" filename ${filename})
+  # ${filename} - without `.c`
+  get_filename_component(filename ${file} NAME)
+  string(REPLACE ".c" "" filename ${filename})
+
+  add_executable(${filename} ${file})
+  target_link_libraries(${filename} PRIVATE atclient)
+  add_test(NAME ${filename} COMMAND $<TARGET_FILE:${filename}>)
+endforeach()
 
-    add_executable(${filename} ${file})
-    target_link_libraries(${filename} PRIVATE atclient)
-    add_test(NAME ${filename} COMMAND $<TARGET_FILE:${filename}>)
-endforeach()
\ No newline at end of file
diff --git a/packages/atclient/tests/test_cjson.c b/packages/atcommons/tests/test_cjson.c
similarity index 96%
rename from packages/atclient/tests/test_cjson.c
rename to packages/atcommons/tests/test_cjson.c
index c5a73c8f..8bc1ac83 100644
--- a/packages/atclient/tests/test_cjson.c
+++ b/packages/atcommons/tests/test_cjson.c
@@ -1,4 +1,4 @@
-#include <cJSON.h>
+#include <atcommons/json.h>
 #include <stddef.h> // IWYU pragma: keep
 #include <stdio.h>
 
diff --git a/tests/functional_tests/tests/test_atclient_notify.c b/tests/functional_tests/tests/test_atclient_notify.c
index 5c931c1d..525ad1c9 100644
--- a/tests/functional_tests/tests/test_atclient_notify.c
+++ b/tests/functional_tests/tests/test_atclient_notify.c
@@ -219,22 +219,22 @@ static int test_2_notify_long_text(atclient *atclient, char *notification_id) {
     goto exit;
   }
 
-  if((ret = atclient_notify_params_set_operation(&params, ATCLIENT_NOTIFY_OPERATION_UPDATE)) != 0) {
+  if ((ret = atclient_notify_params_set_operation(&params, ATCLIENT_NOTIFY_OPERATION_UPDATE)) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set operation: %d\n", ret);
     goto exit;
   }
 
-  if((ret = atclient_notify_params_set_atkey(&params, &atkey)) != 0) {
+  if ((ret = atclient_notify_params_set_atkey(&params, &atkey)) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set atkey: %d\n", ret);
     goto exit;
   }
 
-  if((ret = atclient_notify_params_set_value(&params, VERY_LONG_TEXT)) != 0) {
+  if ((ret = atclient_notify_params_set_value(&params, VERY_LONG_TEXT)) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set value: %d\n", ret);
     goto exit;
   }
 
-  if((ret = atclient_notify_params_set_should_encrypt(&params, true)) != 0) {
+  if ((ret = atclient_notify_params_set_should_encrypt(&params, true)) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set should_encrypt: %d\n", ret);
     goto exit;
   }
@@ -251,4 +251,4 @@ exit: {
   atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_INFO, "test_2_notify_long_text End (%d)\n", ret);
   return ret;
 }
-}
\ No newline at end of file
+}