Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on archive package #1113

Open
gkc opened this issue Sep 1, 2023 · 0 comments
Open

Remove dependency on archive package #1113

gkc opened this issue Sep 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gkc
Copy link
Contributor

gkc commented Sep 1, 2023

Is your feature request related to a problem? Please describe.

In the course of looking more deeply at the issue that led to #1111 being created, I note that our dependency on the archive package is solely in the at_client package's FileTransferService

I don't believe that FileTransferService should be part of the at_client sdk and would like to deprecate it and remove it in a version 4 release of the at_client sdk.

As best I can tell, this class was added to the at_client package to support the AtmospherePro app; however AtmospherePro appears to have its own FileTransferService implementation, thus it should be safe to remove the FileTransferService from the at_client package. (Although see here atsign-foundation/atmosphere_pro#325 for why I can't be entirely definitive about this.)

Describe the solution you'd like

Deprecate FileTransferService and remove it from the version 4 release of the at_client sdk.

Describe alternatives you've considered

No response

Additional context

No response

@gkc gkc added the enhancement New feature or request label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant