We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private key shouldn't be read from preferences anywhere in the atClient code
n/a
#1141 atsign-foundation/at_libraries#434 Once the above tasks are done, we can remove code which read private key from preference
No response
The text was updated successfully, but these errors were encountered:
purnimavenkatasubbu
srieteja
No branches or pull requests
Describe the bug
Private key shouldn't be read from preferences anywhere in the atClient code
Steps to reproduce
n/a
Expected behavior
#1141
atsign-foundation/at_libraries#434
Once the above tasks are done, we can remove code which read private key from preference
_remoteSecondary ??= RemoteSecondary(_atSign, _preference!,
atChops: atChops,
privateKey: _preference!.privateKey,
enrollmentId: _enrollmentId);
Remove the line
privateKey ??= preference.privateKey;
and remove passing of privateKey to AtLookupImpl constructor
atLookUp = AtLookupImpl(atSign, preference.rootDomain, preference.rootPort,
privateKey: privateKey,
cramSecret: preference.cramSecret,
secondaryAddressFinder:
AtClientManager.getInstance().secondaryAddressFinder,
secureSocketConfig: secureSocketConfig,
clientConfig: _getClientConfig());
Screenshots
No response
Smartphones
No response
Were you using an atApplication when the bug was found?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: