We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have onboarding logic duplication in at_onboarding_cli (at_onboarding_service_impl.dart ) and at_client_mobile (at_client_service.dart)
Create a common package that eliminates code duplication at_onboarding_cli and at_client_mobile
No response
The text was updated successfully, but these errors were encountered:
Code duplication between at_onboarding_cli, at_onboarding_flutter, at_client_service
At_onboarding_flutter → onboarding_service.dart Onboard method Calls at_client_service.onboard(..) Authenticate method Check atsign server status Calls at_client_service.authenticate
At_onboarding_cli → at_onboarding_service_impl.dart Onboard method
authenticate method
At_client_mobile → at_client_service.dart (trunk code - no support for pkam secure element)
onboard method //wrong method naming. This method does auth from biometric/atkeys file
Authenticate method
Feature specific to flutter in at_client mobile
Features common to at_client_service and at_onboarding_cli
Sorry, something went wrong.
murali-shris
No branches or pull requests
Is your feature request related to a problem? Please describe.
We have onboarding logic duplication in at_onboarding_cli (at_onboarding_service_impl.dart
) and at_client_mobile (at_client_service.dart)
Describe the solution you'd like
Create a common package that eliminates code duplication at_onboarding_cli and at_client_mobile
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: