Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception handling in at_lookup's BaseConnection.write #716

Open
gkc opened this issue Nov 20, 2024 · 1 comment
Open

exception handling in at_lookup's BaseConnection.write #716

gkc opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gkc
Copy link
Contributor

gkc commented Nov 20, 2024

Describe the bug

While looking at this code in the course of investigating another issue, I observed two problems
(1) exception is silently swallowed
(2) write() is not followed by flush()

Steps to reproduce

n/a

Expected behavior

  • if we want to catch exceptions here rather than via the socket.done error handler, we should await socket.flush() after the call to socket.write()
  • we should rethrow exceptions if they occur

Being part of the core client-side network comms code, changes here have a large blast radius if they introduce a new problem so while the impl here is straightforward, the testing will need to be comprehensive

Screenshots

No response

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@gkc gkc added the bug Something isn't working label Nov 20, 2024
@gkc gkc assigned gkc and unassigned gkc Nov 20, 2024
@murali-shris
Copy link
Member

Will be taken up in PR102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants