From 7a62b0e4b113acdd8997d500247921a89ffbd657 Mon Sep 17 00:00:00 2001 From: gkc Date: Thu, 12 Dec 2024 15:20:32 +0000 Subject: [PATCH] test: removed unnecessary TODOS; updated config12.yaml adding connection type `websocket` --- .github/workflows/at_server.yaml | 4 +--- tests/at_end2end_test/config/config12.yaml | 12 ++++++++---- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/at_server.yaml b/.github/workflows/at_server.yaml index 1f034cb0c..951c24e96 100644 --- a/.github/workflows/at_server.yaml +++ b/.github/workflows/at_server.yaml @@ -569,11 +569,9 @@ jobs: sed -i "s/ATSIGN_1_NAME/@$AT_SIGN_1/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml sed -i "s/ATSIGN_1_PORT/$AT_SIGN_1_PORT/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml sed -i "s/ATSIGN_1_HOST/$AT_SIGN_1_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml - # TODO: add something like sed -i "s/ATSIGN_1_CONNECTION_TYPE/$AT_SIGN_1_CONNECTION_TYPE/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml sed -i "s/ATSIGN_2_NAME/@$AT_SIGN_2/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml sed -i "s/ATSIGN_2_PORT/$AT_SIGN_2_PORT/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml - sed -i "s/ATSIGN_2_HOST/$AT_SIGN_2_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml - # TODO: add something like sed -i "s/ATSIGN_2_CONNECTION_TYPE/$AT_SIGN_2_CONNECTION_TYPE/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml + sed -i "s/ATSIGN_2_HOST/$AT_SIGN_2_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml mv tests/at_end2end_test/config/config-e2e_test_runtime.yaml tests/at_end2end_test/config/config.yaml cat tests/at_end2end_test/config/config.yaml echo "Connection successful" diff --git a/tests/at_end2end_test/config/config12.yaml b/tests/at_end2end_test/config/config12.yaml index b37bb3b51..213e86c5d 100644 --- a/tests/at_end2end_test/config/config12.yaml +++ b/tests/at_end2end_test/config/config12.yaml @@ -8,14 +8,18 @@ root_server: # cicd atsign details first_atsign_server: first_atsign_name: '@cicd1' - # # The port to connect to first atsign server + # The port to connect to first atsign server first_atsign_port: 6464 - # # The url to connect to first atsign server + # The url to connect to first atsign server first_atsign_url: cicd1.atsign.wtf + # The type of connection (socket or websocket) + first_atsign_connection_type: websocket second_atsign_server: second_atsign_name: '@cicd2' - # # The port to connect to second atsign server + # The port to connect to second atsign server second_atsign_port: 6464 - # # The url to connect to second atsign server + # The url to connect to second atsign server second_atsign_url: cicd2.atsign.wtf + # The type of connection (socket or websocket) + second_atsign_connection_type: websocket