Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptake pubKeyHash changes #2121

Closed
murali-shris opened this issue Oct 14, 2024 · 3 comments
Closed

Uptake pubKeyHash changes #2121

murali-shris opened this issue Oct 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

pubKeyCS in metadata currently uses md5 checksum which is outdated.
Refer
atsign-foundation/at_libraries#511

Describe the solution you'd like

Replace pubKeyCS with pubKeyHash using sha512 hash.
Changes are done in at_commons - https://github.com/atsign-foundation/at_libraries/pull/511/files
pubKeyHash should be included in sync from client to server and vice versa.

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris murali-shris added the enhancement New feature or request label Oct 14, 2024
@murali-shris murali-shris self-assigned this Oct 14, 2024
@murali-shris murali-shris added 4 SP 4 Story Points - More than 1 day less than 3 days and removed 4 SP 4 Story Points - More than 1 day less than 3 days labels Oct 14, 2024
@murali-shris murali-shris changed the title Update pubKeyHash changes Uptake pubKeyHash changes Oct 14, 2024
@sitaram-kalluri
Copy link
Member

The changes in at_persistence_secondary_server are completed and changes are available in 2121-uptake-public-key-hash-at-persistence_secondary-server

Pending work is code review and publish the package.

@sitaram-kalluri
Copy link
Member

The changes in at_persistence_secondary_server are released in v3.0.66.

In at_secondary_server, the at_persistence_secondary_server changes are consumed and is released into prod.

There is an open PR for changes in at_secondary_server : #2160

@sitaram-kalluri
Copy link
Member

The changes are released into Canary in c3.1.1. Marking the issue as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants