-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to the social and game channel text fields #154
Comments
Hi @tinashe404 I would like to work on this, if its up for grabs. |
Hi @everly-gif It certainly is! Code away and let us know if you have any questions! |
Hi, I am Palak Jain, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you. |
Hi @Pal18jain, Just a heads up as I am also working on this issue and I believe issues are given first come first serve. |
We will assign the tickets for 3 max. We take PR as first server/the best approach |
Hi @tinashe404 @yahu1031, I am Keyur Gandhi, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you |
@tinashe404 suppose my twitter account url is https://www.twitter.com/keyur45. So I should enter the url or my username (@keyur45) in the text field. Am I right? Also should we check if given url is present or not by sending simple http request? |
@keyurgit45 Yes you are right. And yes, you can check if it's present as one of your forms of validation. |
Is your feature request related to a problem? Please describe.
Currently you are able to enter anything into the text fields in the social and game channel sections of the app. For example, you can enter a facebook link into the Youtube textfield under Social Channels.
Describe the solution you'd like
It would be good to add validation to the text fields so that for example, if the social channel is for facebook it will either only take a username or a facebook url
The social links are shown as static text in the app but they are displayed on wavi.ng as clickable icons. See https://wavi.ng/@barbara
https://wavi.ng/@correspondingdinosaur
Video showing list of channels
https://user-images.githubusercontent.com/69275762/156787755-8e5e473b-11af-4506-baba-a6e7c7603148.mov
The text was updated successfully, but these errors were encountered: