Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to the social and game channel text fields #154

Open
tinashe404 opened this issue Mar 2, 2022 · 8 comments
Open

Add validation to the social and game channel text fields #154

tinashe404 opened this issue Mar 2, 2022 · 8 comments
Assignees
Labels
dart/flutter Requires knowledge of dart and/or flutter Easy An issue with an easy solution that shouldn't take too long enhancement New feature or request OpenForce Any issue with this tag is for participants of Open Force 2022

Comments

@tinashe404
Copy link
Member

tinashe404 commented Mar 2, 2022

Is your feature request related to a problem? Please describe.
Currently you are able to enter anything into the text fields in the social and game channel sections of the app. For example, you can enter a facebook link into the Youtube textfield under Social Channels.

Describe the solution you'd like
It would be good to add validation to the text fields so that for example, if the social channel is for facebook it will either only take a username or a facebook url

The social links are shown as static text in the app but they are displayed on wavi.ng as clickable icons. See https://wavi.ng/@barbara
Screenshot 2022-03-04 at 11 05 11 AM

https://wavi.ng/@correspondingdinosaur
Screenshot 2022-03-04 at 11 05 42 AM

Video showing list of channels
https://user-images.githubusercontent.com/69275762/156787755-8e5e473b-11af-4506-baba-a6e7c7603148.mov

@tinashe404 tinashe404 added enhancement New feature or request Easy An issue with an easy solution that shouldn't take too long OpenForce Any issue with this tag is for participants of Open Force 2022 labels Mar 2, 2022
@everly-gif
Copy link

Hi @tinashe404 I would like to work on this, if its up for grabs.

@tinashe404 tinashe404 added the dart/flutter Requires knowledge of dart and/or flutter label Mar 4, 2022
@tinashe404
Copy link
Member Author

Hi @everly-gif It certainly is! Code away and let us know if you have any questions!

@Pal18jain
Copy link

Hi, I am Palak Jain, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you.

@everly-gif
Copy link

everly-gif commented Mar 5, 2022

Hi @Pal18jain, Just a heads up as I am also working on this issue and I believe issues are given first come first serve.
@tinashe404 @yahu1031

@yahu1031
Copy link
Member

yahu1031 commented Mar 5, 2022

We will assign the tickets for 3 max. We take PR as first server/the best approach

@everly-gif everly-gif removed their assignment Mar 11, 2022
@keyurgit45
Copy link
Contributor

Hi @tinashe404 @yahu1031, I am Keyur Gandhi, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you

@keyurgit45
Copy link
Contributor

keyurgit45 commented Mar 17, 2022

@tinashe404 suppose my twitter account url is https://www.twitter.com/keyur45. So I should enter the url or my username (@keyur45) in the text field. Am I right?

Also should we check if given url is present or not by sending simple http request?

@tinashe404
Copy link
Member Author

@keyurgit45 Yes you are right. And yes, you can check if it's present as one of your forms of validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart/flutter Requires knowledge of dart and/or flutter Easy An issue with an easy solution that shouldn't take too long enhancement New feature or request OpenForce Any issue with this tag is for participants of Open Force 2022
Projects
None yet
Development

No branches or pull requests

5 participants