Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Resource Allocation && Dependency Graph #94

Open
windwhiterain opened this issue Feb 28, 2025 · 2 comments
Open

Automatically Resource Allocation && Dependency Graph #94

windwhiterain opened this issue Feb 28, 2025 · 2 comments
Labels
question Further information is requested

Comments

@windwhiterain
Copy link

After playing with the example "multipass", I found that I still need to explicit "Lease" images or buffer for transient usage. If a chain of operation on a color attachment finally write into "swapchain_image", I can only "copy" the image I leased to swapchain_image rather than telling the graph that all previous operations on that image can be performed directly on swapchain_image.

What's more, I expect "Render Graph" should be a "Dependency Graph". But I didn't found any creation of dependency during building a render graph. After shuffle the order of "begin_pass", I get different result. I think the graph use the order of passes to build a linear dependency, which is not
a "fully featured" render graph I'm afraid.

@attackgoat attackgoat added the question Further information is requested label Feb 28, 2025
@attackgoat
Copy link
Owner

The concept of a lease exists to reduce the number of short-lifespan images, there is no requirement to use them. You may either create images directly or, if you prefer, pass the swapchain image.

If you're getting different results when shuffling the passes I would consider what the passes are actually doing; does it make sense given the shuffling? Doing a read before writes and expecting to read the written data, for example, does not make sense.

I'm open to criticism of the design and welcome constructive feedback, feel free to post code you think should work or things that don't seem correct. If this is more general feedback, perhaps you could use the Discussions tab.

@windwhiterain
Copy link
Author

thanks for reply. i'll make a better post in disscusions tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants