Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need guidelines for contributions #22

Open
lehenry opened this issue Jan 22, 2022 · 3 comments
Open

We need guidelines for contributions #22

lehenry opened this issue Jan 22, 2022 · 3 comments

Comments

@lehenry
Copy link
Contributor

lehenry commented Jan 22, 2022

In order to have consistent styles.
Until now I was removing background images that had no gameplay value.
Which color variable to use in which case is not always clear.
What to do if a style for a game is not in the bgagame-* parent (as it is the case for tooltips)

@audabas
Copy link
Owner

audabas commented Feb 13, 2022

Hi, and sorry for the late reply, I was very busy lately.

Until now I was removing background images that had no gameplay value.

I personally like how custom backgrounds enhance game immersion.
I usually prefer to use dark background if one is already available in options (like for Azul) or daken the current one.

Which color variable to use in which case is not always clear.

Sorry but it's not clear for myself too, haha 😅
I usually use $surface, $lightSurface and $lighterSurface for backgrounds that make a delimitation between areas. Which one to use is totally subjective, depending on how it is important for gameplay and for comfort. Don't worry to much about this as soon as it looks good to you.

$primary is used to replace everything that is blue on default theme (buttons, highlighten text and links, shadows, etc.)

What to do if a style for a game is not in the bgagame-* parent (as it is the case for tooltips)

First look if there are no game specific css classes for these (it happens for some games), if not fix it anyway.
I hope this won't create a bug on another game, but for now it never happened as far as I know.

Anyway thank you for all your contributions lately, that is amazing!
Feel free to make any suggestions if you have any

@audabas audabas pinned this issue Feb 13, 2022
@lehenry
Copy link
Contributor Author

lehenry commented Feb 13, 2022

Thanks :)

By the way, I made a suggestion report on BGA asking them to add the game specific class on tooltips https://boardgamearena.com/bug?id=59022

@audabas
Copy link
Owner

audabas commented Feb 13, 2022

Great! I added my vote, let's hope developers will take this into consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants