Replies: 1 comment 1 reply
-
|
I am playing with setting up rules where each PR needs 1 review before it can be merged. I am not sure if that will be helpful or not. Trying to make this repo sustainable. Could it up so auto merge with the right reviews and passed CIs too. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Just found out this rule doesn't work with release workflow. It blocks it since it isn't a PR. Looks like it isn't easy to bypass that. I disabled for now. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I wanted to get a spot to discuss approach on when to merge PRs etc. I am pretty open to thoughts on approach. I have extended merge and owner abilities to a few others now too.
My thoughts are if not a small fix or cosmetic wait for atleast one other review? Larger commits or rework should be given a few days to receive feedback unless fixing a critical broken item?
Beta Was this translation helpful? Give feedback.
All reactions