Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classPaths property cause cache misses #77

Open
Thrillpool opened this issue Jun 20, 2022 · 3 comments
Open

classPaths property cause cache misses #77

Thrillpool opened this issue Jun 20, 2022 · 3 comments

Comments

@Thrillpool
Copy link

https://github.com/augi/gradle-wartremover/blob/main/src/main/groovy/cz/augi/gradle/wartremover/WartremoverPlugin.groovy#L22

Since the additionalParameters of scalaCompile is modified pre task execution. The scalaCompile task gets an input which is a path on the users machine, and so liable to miss cross machines.

Not sure of the resolution to this issue.

@augi
Copy link
Owner

augi commented Jun 21, 2022

Hello, the latest version of this plugin uses configureEach method to handle Task Configuration Avoidance. Please check if this solves your issue 🙏

@Thrillpool
Copy link
Author

Hey will check soon sorry for the delay

@Thrillpool
Copy link
Author

Hello, unfortunately it still causes a cache miss. The modification still finds it's way into the cache key for scalaCompile task. I think the issue is that the configuration avoidance doesn't help us, in this case, because we really are running the scalaCompile task, so it will be configured.

I suspect what needs to be done is that somehow rather than having the input key consist of the classpath, it needs to consist of the hash of the classpath. But I don't know if it's actually possible, because wartremover probably only knows to look for these specially named properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants