Provide NFData1 and NFData2 from Control.DeepSeq

[meooow25]

haskell/containers#992 defines NFData1 and NFData2 instances, but they are not available in MicroHs. Could these be added?

[augustss]

No. They require the QualifiedConstraints extension, and I have not implemented that yet.

[augustss]

For now you'll have to #ifdef out the code for MicroHs.

[meooow25]

Eq1, Eq2, etc. are currently defined, just without the quantified constraints. Could we do the same thing for NFData1?

[augustss]

Maybe. I can try, and see what happens.

[augustss]

I've added NFData1 and NFData2 and updated my PR to use the updated mhs version.

[meooow25]

mhs: error: "src/Data/Set/Internal.hs": line 246, col 37: not exported: NFData1

It looks they are not exported 😄

[augustss]

Arg! Fixed.

…

On Sat, Jan 4, 2025 at 1:11 PM Soumik Sarkar ***@***.***> wrote: mhs: error: "src/Data/Set/Internal.hs": line 246, col 37: not exported: NFData1 It looks they are not exported 😄 — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIARHUI366W6CUEUWAPEFL2I7FWPAVCNFSM6AAAAABUOYCT5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGI3TAMBQG4> . You are receiving this because you commented.Message ID: ***@***.***>

[meooow25]

Is there a new stable- tag? I'm not seeing it.
If there is one I can just update to it in the NFData1 PR (haskell/containers#992).
(I merged the existing MicroHs PR (haskell/containers#1081) before I saw the problem)

[augustss]

There should be a stable-5 tag

[augustss]

But I've not put stable-5 in a PR. Maybe you can change it when you try the NFdata1/2 stuff?

[meooow25]

Ah you pushed the fix to the stable-5 branch, I didn't realize.

But I've not put stable-5 in a PR.

You did in haskell/containers#1081.

I re-ran the CI for haskell/containers#992 and it passed, so we're good there. Thank you!