Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameters.rs to another crate #486

Open
karim-en opened this issue Apr 8, 2022 · 3 comments
Open

Move parameters.rs to another crate #486

karim-en opened this issue Apr 8, 2022 · 3 comments
Assignees

Comments

@karim-en
Copy link
Contributor

karim-en commented Apr 8, 2022

While working on the cross contract call, I ran into a problem with import engine types to interact with Aurora contract.
It should be possible to import the input and output types from other libs without importing the engine crate, so those types could be moved to engine-types.

@karim-en karim-en assigned karim-en and birchmd and unassigned karim-en Apr 8, 2022
@joshuajbouw
Copy link
Contributor

Excellent, will get this tasked.

@joshuajbouw joshuajbouw assigned mrLSD and unassigned birchmd Apr 8, 2022
@mrLSD
Copy link
Member

mrLSD commented Apr 8, 2022

@karim-en If you look closely at the code, you can see in some places there is a very strong interweaving with engine crate. This means that these parameters cannot simply be taken and transferred. Therefore, it will be great if you give specific suggestions.

@karim-en
Copy link
Contributor Author

karim-en commented Apr 9, 2022

@mrLSD hm, at least we can move part of them and then think about types with hard links. For example I was already able to move the SubmitResult to temporarily lib.

Definitely the copy past will not works, so some refactoring should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants