Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminControlled: use call() pattern for transferring ether #506

Open
sept-en opened this issue May 16, 2022 · 0 comments
Open

AdminControlled: use call() pattern for transferring ether #506

sept-en opened this issue May 16, 2022 · 0 comments
Assignees
@sept-en
Labels
A-connector Area: Issues that relate to the connector. C-enhancement Category: New feature or request

Comments

@sept-en
Copy link
Contributor

sept-en commented May 16, 2022 •
edited
Loading

Currently, AdminControlled contract uses transfer() method to transfer ether in adminSendEth() method. Even though this method is not utilized at the moment, it's recommended to change it for the future as transfer() gas provided might change.
The suggested change is to use .call{value:amount}("") pattern.
@sept-en sept-en added C-enhancement Category: New feature or request A-connector Area: Issues that relate to the connector. labels May 16, 2022
@sept-en sept-en self-assigned this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sept-en sept-en

Labels
A-connector Area: Issues that relate to the connector. C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sept-en