Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from near-sdk-sim to workspaces-rs #518

Open
birchmd opened this issue Jun 3, 2022 · 0 comments
Open

Migrate from near-sdk-sim to workspaces-rs #518

birchmd opened this issue Jun 3, 2022 · 0 comments
Assignees
@hskang9
Labels
A-testing Area: If something has added tests, or changed them. C-dependencies Category: Pull requests that update a dependency P-high Pririoty: high

Comments

@birchmd
Copy link
Member

birchmd commented Jun 3, 2022

NEAR deprecated near-sdk-sim a long time ago now, and at this point it has been entirely removed from their code base.

We still depend on it for important tests (particularly tests for the eth and erc20 connectors). To keep those tests functioning we have had to fork near-sdk-rs and now nearcore itself (see #517 (comment)). This is a serious maintenance burden going forward because these forks need to be updated with each new NEAR release.

To resolve this tech debt we must migrate from near-sdk-sim to workspaces-rs which has superseded it.
@birchmd birchmd added C-dependencies Category: Pull requests that update a dependency A-testing Area: If something has added tests, or changed them. labels Jun 3, 2022
@birchmd birchmd mentioned this issue Jun 3, 2022
Merged
@joshuajbouw joshuajbouw added the P-high Pririoty: high label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hskang9 hskang9

Labels
A-testing Area: If something has added tests, or changed them. C-dependencies Category: Pull requests that update a dependency P-high Pririoty: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuajbouw @hskang9 @birchmd