Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic tests for new metadata #14

Open
10 tasks
mfornet opened this issue Oct 28, 2021 · 0 comments
Open
10 tasks

Automatic tests for new metadata #14

mfornet opened this issue Oct 28, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mfornet
Copy link
Contributor

mfornet commented Oct 28, 2021 •
edited
Loading

When a new PR is created with the format Add <SYMBOL_OF_YOUR_ERC20_TOKEN> metadata trigger some automatic tests to avoid merging invalid metadata, or invalid format. This will improve significantly workflow for the reviewer.

This is list (potentially non-comprehensive) of required tests for a PR to be approved.

  • Ethereum address must exist
  • Ethereum address must have proper checksum (online tool for this: https://ethsum.netlify.app/)
  • ?Aurora address must exist?
  • ?Aurora address must have proper checksum?
  • name must match metadata from ethereum
  • symbol must match metadata from ethereum
  • decimals must match metadata from ethereum
  • icon data must match svg file
  • icon is a optimized svg as suggested in the standard (in particular it should be less than 8kb)
  • NEP-141 has aurora registered for storage
@mfornet mfornet added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfornet