Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Per Discord Webhook #213

Open
aussig opened this issue Apr 8, 2024 · 1 comment
Open

Language Per Discord Webhook #213

aussig opened this issue Apr 8, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@aussig
Copy link
Owner

aussig commented Apr 8, 2024 •
edited
Loading

In the current pre-release implementation, the Discord language applies to all webhooks. It would be more useful to be able to set a language per webhook.

Leave the current overarching language selector in place:

  • Add an override checkbox to apply to all webhooks.
  • When adding a new webhook, use the language chosen in the main selector.
@aussig aussig added the enhancement New feature or request label Apr 8, 2024
@aussig aussig added this to the 4.0.0 milestone Apr 8, 2024
aussig added a commit that referenced this issue Apr 10, 2024
@aussig
WIP on support for multiple output formatters.
cacbc1c 
Implement `FormatterInterface` base class.
Split out all formatting code from `Activity` to new `DefaultFormatter`.
Start on groundwork for supporting language per webhook.
Relates to #195. Relates to #213.
@aussig
Copy link
Owner Author

aussig commented Apr 10, 2024 •
edited
Loading

The text is currently created once first, and then passed into the Discord class for posting. Instead, we'll need to re-work the way the text is generated so that it is done each time per webhook.

One way would be to pass in a dict containing text in all languages, but that is overkill as only one or two languages are likely to be used.

Better approach is to pass in a callable to the discord posting functions, which is called to fetch the text in the appropriate language as the posting function iterates through each webhook.

@aussig aussig modified the milestones: 4.0.0, 4.1.0 May 8, 2024
@aussig aussig modified the milestones: 4.1.0, Backlog Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@aussig