Fix the way we pass around creds so we stop using hard coded numbers....

austinkregel · Jan 1, 2024 · b224f73 · b224f73
1 parent 6419f0d
commit b224f73
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/app/Jobs/CloudflareSyncAndPurgeJob.php b/app/Jobs/CloudflareSyncAndPurgeJob.php
@@ -34,7 +34,7 @@ public function handle(DomainServiceFactory $serviceFactory)
     public function sync(): void
     {
         $page = 1;
-        $registrarService = (new RegistrarServiceFactory)->make(Credential::find(2));
+        $registrarService = (new RegistrarServiceFactory)->make($this->credential);
 
         do {
             $domains = $this->service->getDomains(100, $page++);

diff --git a/app/Jobs/FetchCloudflareAnalytics.php b/app/Jobs/FetchCloudflareAnalytics.php
@@ -15,11 +15,15 @@ class FetchCloudflareAnalytics implements ShouldQueue
 
     public function handle()
     {
-        $service = new \App\Services\Domain\CloudflareDomainService(Credential::find(4));
-        $domains = \App\Models\Domain::whereNotNull('cloudflare_id')->get();
+        $services = Credential::where('service', 'cloudflare')->get();
 
-        foreach ($domains as $domain) {
-            $service->getAnalytics($domain, now()->subDay()->startOfDay(), now()->endOfDay());
+        foreach ($services as $service) {
+            $service = new \App\Services\Domain\CloudflareDomainService($service);
+            $domains = \App\Models\Domain::whereNotNull('cloudflare_id')->get();
+
+            foreach ($domains as $domain) {
+                $service->getAnalytics($domain, now()->subDay()->startOfDay(), now()->endOfDay());
+            }
         }
     }
 }
diff --git a/database/migrations/2023_10_15_205749_create_navigations_table.php b/database/migrations/2023_10_15_205749_create_navigations_table.php
@@ -48,14 +48,14 @@ public function up(): void
         \App\Models\Navigation::create([
             'name' => 'Banking',
             'icon' => 'WalletIcon',
-            'href' => '/-/',
+            'href' => '/-/banking',
             'order' => 6,
             'authentication_required' => true,
         ]);
         \App\Models\Navigation::create([
             'name' => 'Tags',
             'icon' => 'TagIcon',
-            'href' => '/-/',
+            'href' => '/-/tag-manager',
             'order' => 8,
             'authentication_required' => true,
         ]);