Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes from #654. Fix renew Credentials logic #670

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Revert changes from #654. Fix renew Credentials logic #670

merged 1 commit into from
Jul 17, 2023

Conversation

poovamraj
Copy link
Contributor

Changes

We are reverting changes from #654

This changes caused a regression were existing credentials were not fetched with the same scope. This can cause access tokens to have lesser access. To fix this we are reverting this change and ensuring the scope parameter is empty if none is specified.

References

#654

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

@poovamraj poovamraj requested a review from a team as a code owner July 17, 2023 17:01
@poovamraj poovamraj mentioned this pull request Jul 17, 2023
Merged
3 tasks
@poovamraj poovamraj merged commit f90820e into main Jul 17, 2023
@poovamraj poovamraj deleted the revert-renew-auth-changes branch July 17, 2023 17:17
@poovamraj poovamraj mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poovamraj @evansims