Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript compilation for 4.6.3 #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steaks
Copy link

@steaks steaks commented Oct 21, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fixes #811. This PR fixes compilation for on Typescript 4.6.3. It still works on 4.9.

I tried the simplest solution - casting the variable to the known type.

References

Include any links supporting this change such as a:

-#811

  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

  1. Change typescript version to 4.6.3 in package.json
  2. Change moduleResolution to node in tsconfig.json
  3. npm install (may need to clean first)
  4. npx tsc -b
  5. See no compilation errors

Developed on Ubuntu 22.04.5 LTS. Tested in Chrome 129.0.6668.58 (Official Build) (64-bit). Tested in Firefox 131.0.3 (64-bit).

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@steaks steaks requested a review from a team as a code owner October 21, 2024 02:54
@steaks
Copy link
Author

steaks commented Nov 18, 2024

Hey Auth0 team. It's been a month since I created this PR. I'm not sure what to do here. Should I close this PR or reach out to someone for a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript compilation error
1 participant