fix: update dependencies to fix Snyk reports #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-tomlinson
commented
Jun 9, 2023
| @@ -20,9 +20,9 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@auth0/thumbprint": "0.0.6", | |||
| "ejs": "2.5.5", | |||
| "ejs": "^3.1.9", | |||
There was a problem hiding this comment.
The reasons for major bump are documented here:
* Removed require.extensions (@mde)
* Removed legacy preprocessor include (@mde)
* Removed support for EOL Nodes 4 and 6 (@mde)
We aren't using require.extensions.
We aren't using include in our templates.
Support for Node < 12 was dropped in version 7 of node-wsfed.
| "jsonwebtoken": "^9.0.0", | ||
| "saml": "^1.0.0", | ||
| "saml": "^3.0.1", |
There was a problem hiding this comment.
Reasons for major bump:
1 -> 2: Require Node >= 12.
2 -> 3: Handle poorly formatted PEM files.
6footgeek
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://app.snyk.io/vuln/SNYK-JS-EJS-2803307
https://app.snyk.io/vuln/SNYK-JS-MOMENT-2944238
https://app.snyk.io/vuln/SNYK-JS-MOMENT-2440688
https://app.snyk.io/vuln/SNYK-JS-NODEFORGE-2430339
References
https://auth0team.atlassian.net/browse/IPS-3216
https://auth0team.atlassian.net/browse/ESD-28779
Testing
Checklist