Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the bootstrap overwrite flag actually fully overwrites #1983

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Ensure that the bootstrap overwrite flag actually fully overwrites #1983

merged 1 commit into from
Jul 12, 2024

Conversation

josephschorr
Copy link
Member

Fixes #1982

@josephschorr josephschorr requested a review from a team as a code owner July 11, 2024 21:09
@github-actions github-actions bot added the area/CLI Affects the command line label Jul 11, 2024
vroldanbet
vroldanbet approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's scary to add such a method and the possibility of doing such a thing, but I'm hopeful it's evident behind a BootstrapOverwrite flag.

@vroldanbet vroldanbet added this pull request to the merge queue Jul 12, 2024
Merged via the queue into authzed:main with commit fc0d606 Jul 12, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@josephschorr josephschorr deleted the datastore-overwrite branch July 12, 2024 14:45
@josephschorr
Copy link
Member Author

@vroldanbet Yeah

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--datastore-bootstrap-overwrite is additive, not overwriting previous namespaces
2 participants
@josephschorr @vroldanbet