Skip to content

Commit 201fa1c

Browse files
committed
feat: notion connection - hide oauth by feature flag
1 parent 0a88b67 commit 201fa1c

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

src/constants/featureFlags.constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export const featureFlags = {
66
salesforceHideDefaultOAuth: import.meta.env.VITE_SALESFORCE_HIDE_DEFAULT_OAUTH,
77
zoomHideDefaultOAuth: import.meta.env.VITE_ZOOM_HIDE_DEFAULT_OAUTH,
88
microsoftHideDefaultOAuth: import.meta.env.VITE_MICROSOFT_HIDE_INTEGRATION,
9+
notionHideDefaultOAuth: import.meta.env.VITE_NOTION_HIDE_DEFAULT_OAUTH,
910
telegramHideIntegration: import.meta.env.VITE_HIDE_TELEGRAM_CONN,
1011
pipedriveHideIntegration: import.meta.env.VITE_PIPEDRIVE_HIDE_INTEGRATION,
1112
sendDotEmptyTriggerFilter: import.meta.env.VITE_SEND_DOT_EMPTY_TRIGGER_FILTER,

src/constants/lists/connections/options.constants.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,11 @@ export const selectIntegrationConfluence: SelectOption[] = [
255255
{ label: "User API Token / PAT", value: ConnectionAuthType.ApiToken },
256256
];
257257

258+
const notionDisplayOAuth = featureFlags.notionHideDefaultOAuth
259+
? []
260+
: [{ label: "OAuth v2 - Default app", value: ConnectionAuthType.OauthDefault }];
261+
258262
export const notionIntegrationAuthMethods: SelectOption[] = [
259-
{ label: "OAuth v2 - Default app", value: ConnectionAuthType.OauthDefault },
263+
...notionDisplayOAuth,
260264
{ label: "API Key", value: ConnectionAuthType.ApiKey },
261265
];

src/vite-env.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ interface ImportMetaEnv {
2222
readonly VITE_ZOOM_HIDE_DEFAULT_OAUTH: boolean;
2323
readonly VITE_SALESFORCE_HIDE_DEFAULT_OAUTH: boolean;
2424
readonly VITE_MICROSOFT_HIDE_INTEGRATION: boolean;
25+
readonly VITE_NOTION_HIDE_DEFAULT_OAUTH: boolean;
2526
readonly VITE_HIDE_TELEGRAM_CONN: boolean;
2627
readonly VITE_PIPEDRIVE_HIDE_INTEGRATION: boolean;
2728
readonly VITE_SEND_DOT_EMPTY_TRIGGER_FILTER: boolean;

vite.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export default defineConfig({
6767
"import.meta.env.VITE_LINEAR_HIDE_DEFAULT_OAUTH": process.env.VITE_LINEAR_HIDE_DEFAULT_OAUTH,
6868
"import.meta.env.VITE_ZOOM_HIDE_DEFAULT_OAUTH": process.env.VITE_ZOOM_HIDE_DEFAULT_OAUTH,
6969
"import.meta.env.VITE_MICROSOFT_HIDE_INTEGRATION": process.env.VITE_MICROSOFT_HIDE_INTEGRATION,
70+
"import.meta.env.VITE_NOTION_HIDE_DEFAULT_OAUTH": process.env.VITE_NOTION_HIDE_DEFAULT_OAUTH,
7071
"import.meta.env.VITE_HIDE_TELEGRAM_CONN": process.env.VITE_HIDE_TELEGRAM_CONN,
7172
"import.meta.env.VITE_SEND_DOT_EMPTY_TRIGGER_FILTER": process.env.VITE_SEND_DOT_EMPTY_TRIGGER_FILTER,
7273
"import.meta.env.VITE_SALESFORCE_HIDE_DEFAULT_OAUTH": process.env.VITE_SALESFORCE_HIDE_DEFAULT_OAUTH,

0 commit comments

Comments
 (0)