Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencies to allow for HandBrake QSV support #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DZaremba14600
Copy link

This is my first git/github submission ever.

I apologize if I miss any protocols, my intent is not to irritate.

I tried to comment appropriately, if its too much/not enough just let me know.

If the project maintainers would prefer other protocols or policies be followed, just let me know.

An earlier version of these changes was used by me to process close to 60 BluRay movies and they processed very quickly (less than 2 hours per disk average over parts of 4 days (on 2 machines) and without error. I tweaked the code, cleaned up the comments, and ran several Docker Image builds to make sure there weren't any errors in the builds. I had to get up on how git worked. So here's my submission.

Added support for Handbrake to support use of QSV.

The only file changed is scripts/install_mkv_hb_deps.sh

Added code to add repository for Intel graphics GPU support. This will allow latest packages to be pulled.
Added an update/upgrade step to get latest packages index list and upgrade all existing packages.
Added step to install packages for OneVPL Compute Runtime, Media, and Mesa packages, misc utils, for QSV use in HandBrake.
Added step to install specific QSV packages as called for by HandBrake's website.
Added step to install new HandBrake version 1.9 dependencies. These seem identical to the previously included HandBrake dependencies installed at line 21. Identical packages will be upgrade/skipped; any different packages will be installed (this being the case, line 21 could actually be removed/merged with line 78. I decided to code this way to ensure everything is shown to be working through widespread use, and in the next update these redundant lines could be merged or line 21 removed/replaced.
Added step to include GTK library packages (used in HandBrake GUI). Even though this is CLI only, there is functionality in place to allow easy use of custom PRESETS on the handbrake args line using .json files exported from the GUI version. During testing there seemed to be issues unless these were included. They can be removed if further use show them to be unnecessary.

Testing shows this builds and the Docker Container comes up and runs. Obviously I didn't test every function of ARM, but I did run ARM and processed the BluRay of 'Unforgiven', using latest Handbrake 1.9, a custom preset that utilizes QSV, and the job completed without errors.

Thank you.

@microtechno9000
Copy link
Collaborator

Thanks for the first commit

There are no specific rules setup for the ARM dependencies

I will check this on my machine to check it doesn't break containers with no QSV cards.

Wont get to this till after Christmas

Thanks for helping the community

@microtechno9000 microtechno9000 self-assigned this Dec 20, 2024
@DZaremba14600
Copy link
Author

DZaremba14600 commented Dec 21, 2024 via email

@microtechno9000 microtechno9000 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants