New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fANOVA crashes on depths larger than two #197

Open

Michael190502 opened this issue Dec 11, 2024 · 0 comments

Michael190502 commented Dec 11, 2024

Hi,

I think I found a potential bug in the following line https://github.com/automl/DeepCAVE/blob/58d6801508468841eda038803b12fa2bbf7a0cb8/deepcave/evaluators/epm/fanova_forest.py#L214C26-L214C43 . Shouldnt is be self.compute_marginals(sub_hp_ids, k)? If I am not mistaken the current implementation blocks the computation of marginals of sets larger than 2 as the compute marginal function returns empty lists if depth + 1 is greater than len(hp_ids) and the default depth is 1.

Concretely I get an IndexError for vu_total for subsets larger than 2 in the current implementation.

If I missed something please let me know. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment