Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code in robo.acquisition_functions.marginalization.py #109

Open
cjfcsjt opened this issue Apr 26, 2019 · 1 comment
Open

code in robo.acquisition_functions.marginalization.py #109

cjfcsjt opened this issue Apr 26, 2019 · 1 comment

Comments

@cjfcsjt
Copy link

cjfcsjt commented Apr 26, 2019

should we change code line 75 :
"estimator.model = None" to "estimator.cost_model"
and change code line 77:
"estimator.model = self.cost_model.models[I]" to "estimator.cost_model = self.cost_model.models[I]"

and should we delete delete line 33-47?
@aaronkl
Copy link
Contributor

aaronkl commented Apr 30, 2019

Good catch! Could you send a pull request to change that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronkl @cjfcsjt