Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard coded indices in RunHistory #1174

Open
thijssnelleman opened this issue Nov 29, 2024 · 3 comments
Open

Replace hard coded indices in RunHistory #1174

thijssnelleman opened this issue Nov 29, 2024 · 3 comments
Assignees

Comments

@thijssnelleman
Copy link

Description

In the RunHistory class, when loading data from a file, quite some data on an entry level is being extracted by using hard coded indices of a list. This is very error prone and can lead to older runhistories no longer to work with a new release.

Possible Solution

Store the information as a dictionary instead so we can do key/value matching for each stored attribute.

Versions

2.2.0

@LukasFehring
Copy link
Collaborator

Hey Thijs,
First, thank you for raising the issue, and I will immediately start to get on it. However, an adapted runhistory might not be included in the next release because of chain dependencies.

Talking about the issue: Are you referring to the list of previously evaluated configurations reporting the different performances?

@thijssnelleman
Copy link
Author

I believe its within the reader part of the runhistory, where it on some lower level of the .json determines which value represents what using hardcoded indexes

@LukasFehring
Copy link
Collaborator

LukasFehring commented Dec 2, 2024

Are you referencing #1085 or something else?
I just want to make sure, that I grasp all of the current issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants