Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset.append should validate categorical data #3

Open
anthonytw opened this issue Jun 3, 2020 · 0 comments
Open

Dataset.append should validate categorical data #3

anthonytw opened this issue Jun 3, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@anthonytw
Copy link
Member

Currently Dataset.append does no validation on categorical members, it appends whatever is sent. This might break things if append is called on a categorical series where the labels have been renumbered or new labels have been added. Validation should happen by default to correct appends if necessary, or raise an exception.

@anthonytw anthonytw added bug Something isn't working enhancement New feature or request labels Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant