Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple pending transaction could never resolve #772

Open
marc-aurele-besner opened this issue Jul 26, 2024 · 4 comments
Open

Multiple pending transaction could never resolve #772

marc-aurele-besner opened this issue Jul 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@marc-aurele-besner
Copy link
Collaborator

Multiple pending transactions could never resolve

When adding nonce management, opened the door to an edge case.

if you send tx 1 but for one reason or another (like bad internet) the rpc never receives the tx or drops it.
The user (and nonce manager) assume this nonce is used, but there is no tx with that nonce, so any other tx you send will be to a further nonce creating a gap and nothing get resolved.

So either we remove the part that check the last pending tx nonce use and use -1 instead if no nonce is provided, or we call the pending pool actually to check if these pending tx are still in it...

@marc-aurele-besner marc-aurele-besner self-assigned this Jul 26, 2024
@marc-aurele-besner
Copy link
Collaborator Author

@DianaPertseva this is the issue you are experiencing as far as I understand it!

@marc-aurele-besner marc-aurele-besner added the bug Something isn't working label Jul 26, 2024
@marc-aurele-besner
Copy link
Collaborator Author

The issue was actually the rpc been out of sync

@marc-aurele-besner
Copy link
Collaborator Author

Add option to retry transaction?

@DianaPertseva
Copy link

Yes, great idea! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants