Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fresh node start with Snap sync failing #3266

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

nazar-pc
Copy link
Member

Regression from recent object mappings changes. For regular node operation it doesn't matter if state exists, which it will not for parent of genesis block anyway since there can't be state for genesis block anyway.

Without this node with regular Snap sync (including Space Acres) fails like this:

Error: SubstrateService(Other("Failed to build a full subspace node 3: Sub(Client(Application("Missing state for mapping block 0 hash 0x6645…21bd: Api called for an unknown Block: Header was not found in the database: 0x0000000000000000000000000000000000000000000000000000000000000000, try a higher block number, or wipe your node and restart with --sync full")))"))

Code contributor checklist:

@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner November 28, 2024 04:08
@nazar-pc nazar-pc enabled auto-merge November 28, 2024 04:09
@nazar-pc nazar-pc disabled auto-merge November 28, 2024 04:37
@nazar-pc nazar-pc merged commit 16118da into main Nov 28, 2024
8 checks passed
@nazar-pc nazar-pc deleted the fix-fresh-node-start-with-snap-sync branch November 28, 2024 04:37
@teor2345
Copy link
Contributor

teor2345 commented Dec 2, 2024

Thanks for fixing this, and sorry about the bug. I jumped too quickly from mappings to execution work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants