From 9791a4a0b0d4816ce2f6efa6781fb35acca4284f Mon Sep 17 00:00:00 2001 From: Meina Li Date: Thu, 19 Dec 2024 22:18:12 -0500 Subject: [PATCH] sriov: fix ipxe rom file issue Relying on ipxe build in tests when cannot obtain VF pxe rom file is an unstable testing method. Because this case is mainly to test the xml but not the pxe function. So we decided to use the fixed virtio rom file to test. Signed-off-by: Meina Li --- provider/sriov/sriov_base.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/provider/sriov/sriov_base.py b/provider/sriov/sriov_base.py index a908fa75ce..7b0914afba 100644 --- a/provider/sriov/sriov_base.py +++ b/provider/sriov/sriov_base.py @@ -258,12 +258,11 @@ def get_rom_file(self): rom_vendor_device = lspci_stdout[1:-1].replace(':', '') + '.rom' rom_file = os.path.join('/usr/share/ipxe', rom_vendor_device) if not os.path.exists(rom_file): - build_cmd = "git clone https://github.com/ipxe/ipxe.git;\ - pushd ipxe/src; make bin/{0}; cp bin/{0} {1}; popd; \ - rm -rf ipxe".format(rom_vendor_device, rom_file) - process.run(build_cmd, shell=True, verbose=True) + # Directly use virtio rom file because it mainly test xml but not pxe function. + rom_file = "/usr/share/ipxe/1af41000.rom" if not os.path.exists(rom_file): - self.test.error("This test needs rom file: %s." % rom_file) + self.test.error("This test needs rom file but the virtio rom file also doesn't exist: %s." + % rom_file) return rom_file def create_iface_dev(self, dev_type, iface_dict):