Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual_disks: stabilize tests that check a new disk was added #5060

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

smitterl
Copy link
Contributor

@smitterl smitterl commented Jul 27, 2023

Depends on avocado-framework/avocado-vt#3729

Partition names under /cat/partitions might change
between boots, causing tests to fail in those cases.

Use instead information under /dev/disk/by-path.

Note, that pci disks might be listed twice, e.g.

'virtio-pci-0000:04:00.0-part1' and 'pci-0000:04:00.0-part1'.

Furthermore,

virtual_disk_ndb: remove unused parameter

startupPolicy: disable floppy, sata - not available on s390x

@smitterl smitterl force-pushed the ndb_fix_s390x branch 6 times, most recently from e8c23b1 to 1e812a8 Compare July 27, 2023 15:23
@smitterl smitterl marked this pull request as draft July 27, 2023 15:36
@smitterl smitterl changed the title virtual_disks_nbd: stabilize test on s390x virtual_disks: stabilize tests on s390x Jul 27, 2023
@smitterl smitterl changed the title virtual_disks: stabilize tests on s390x virtual_disks: stabilize tests that check a new disk was added Jul 28, 2023
@smitterl smitterl force-pushed the ndb_fix_s390x branch 2 times, most recently from 4d70333 to b695554 Compare July 28, 2023 14:15
Partition names under /cat/partitions might change
between boots, causing tests to fail in those cases.

Use instead information under /dev/disk/by-path.

Note, that pci disks might be listed twice, e.g.

'virtio-pci-0000:04:00.0-part1' and 'pci-0000:04:00.0-part1'.

Furthermore,

virtual_disk_ndb: remove unused parameter

startupPolicy: disable floppy, sata - not available on s390x

Signed-off-by: Sebastian Mitterle <[email protected]>
@smitterl
Copy link
Contributor Author

smitterl commented Aug 2, 2023

RHEL 9 s390x

JOB ID     : 3b2a5a3164dbbc6d36e55e56e36d833896bde283                                                                                                                                                                                                         
JOB LOG    : /var/lib/avocado/job-results/job-2023-08-02T07.16-3b2a5a3/job.log                                                                                                                                                                                
 (01/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.mandatory.device_type.cdrom.volume.iscsi_pool: PASS (36.90 s)                                                                                                                  
 (02/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.mandatory.device_type.cdrom.volume.dir_pool: PASS (30.17 s)                                                                                                                    
 (03/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.mandatory.device_type.disk.virtio_bus.volume.dir_pool: ERROR: Command 'qemu-img snapshot /var/lib/avocado/data/avocado-vt/images/jeos-27-s390x.qcow2 -d 1' failed.\nstdout: b''
\nstderr: b"qemu-img: Could not delete snapshot '1': snapshot not found\n"\nadditional_info: None (34.92 s)                                                                                                                                                   
 (04/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.optional.device_type.cdrom.volume.iscsi_pool: PASS (38.66 s)                                                                                                                   
 (05/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.optional.device_type.cdrom.volume.dir_pool: PASS (30.94 s)                                                                                                                     
 (06/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.optional.device_type.disk.virtio_bus.volume.dir_pool: PASS (34.42 s)                                                                                                           
 (07/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.requisite.device_type.cdrom.volume.iscsi_pool: PASS (38.70 s)                                                                                                                  
 (08/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.requisite.device_type.cdrom.volume.dir_pool: PASS (30.49 s)                                                                                                                    
 (09/22) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.requisite.device_type.disk.virtio_bus.volume.dir_pool: PASS (13.42 s)                                                                                                          
 (10/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.attach_disk.associate_flag_seclabel_default: PASS (26.28 s)                                                                                                          
 (11/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.attach_disk.associate_flag_seclabel_restore: PASS (27.36 s)                                                                                                          
 (12/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.attach_disk.associate_flag_seclabel_writable.normal_disk: PASS (27.26 s)                                                                                             
 (13/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.attach_disk.associate_flag_seclabel_writable.readonly_disk: PASS (26.05 s)                                                                                           
 (14/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.attach_disk.associate_flag_seclabel_restore_writable: PASS (26.16 s)                                                                                                 
 (15/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.save_restore.associate_flag_seclabel_default: PASS (30.37 s)                                                                                                         
 (16/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.save_restore.associate_flag_seclabel_restore: PASS (29.77 s)                                                                                                         
 (17/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.save_restore.associate_flag_seclabel_writable.normal_disk: PASS (28.65 s)                                                                                            
 (18/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.coldplug.save_restore.associate_flag_seclabel_restore_writable: PASS (30.13 s)                                                                                                
 (19/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.hotplug.attach_disk.associate_flag_seclabel_default: PASS (20.65 s)                                                                                                           
 (20/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.hotplug.attach_disk.associate_flag_seclabel_restore: PASS (20.94 s)                                                                                                           
 (21/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.hotplug.attach_disk.associate_flag_seclabel_writable.normal_disk: PASS (20.79 s)                                                                                              
 (22/22) type_specific.io-github-autotest-libvirt.virtual_disks.file_descriptor.hotplug.attach_disk.associate_flag_seclabel_restore_writable: PASS (20.71 s)                                                                                                  
RESULTS    : PASS 21 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0                                             
JOB HTML   : /var/lib/avocado/job-results/job-2023-08-02T07.16-3b2a5a3/results.html                                            
JOB TIME   : 624.64 s                                          

startup_policy.startupPolicy.mandatory.device_type.disk.virtio_bus.volume.dir_pool fails on RHEL 9 where it's not supported but skipped but passes on RHEL 8:

JOB ID     : 1133ab99367ace1a1cefbd5c609f2de3de07cd31
JOB LOG    : /var/lib/avocado/job-results/job-2023-08-02T08.19-1133ab9/job.log
 (1/1) type_specific.io-github-autotest-libvirt.startup_policy.startupPolicy.mandatory.device_type.disk.virtio_bus.volume.dir_pool: PASS (33.79 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-08-02T08.19-1133ab9/results.html
JOB TIME   : 34.30 s

Also, run these tests on x86_64, same result.

@smitterl smitterl marked this pull request as ready for review August 2, 2023 12:22
@dzhengfy dzhengfy added the depend on The PR has dependency on other PRs label Aug 11, 2023
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunfuwen
Copy link
Contributor

known minor fix, mark it as minor_fix

@chunfuwen chunfuwen merged commit 2b78825 into autotest:master Sep 6, 2023
4 checks passed
@smitterl smitterl deleted the ndb_fix_s390x branch November 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depend on The PR has dependency on other PRs minorfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants