add case for period config of memballoon #5206

nanli1 · 2023-09-26T13:10:14Z

VIRT-299028: Period config of memory balloon

Signed-off-by: nanli [email protected]

avocado-framework/avocado-vt#3768

RHE9 & RHEL8+x86

 avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35  memory.balloon.period

 (1/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_model: PASS (26.70 s)
 (2/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_trans_model: PASS (32.40 s)
 (3/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_non_trans_model: PASS (32.96 s)
 (4/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_model: PASS (32.76 s)
 (5/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_trans_model: PASS (32.96 s)
 (6/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_non_trans_model: PASS (32.71 s)

RHE9+Aarch64

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type arm64-mmio  memory.balloon.period 

(1/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_model: PASS (60.59 s)
(2/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_trans_model: PASS (66.13 s)
(3/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.undefined_period.virtio_non_trans_model: PASS (63.73 s)
(4/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_model: PASS (64.28 s)
(5/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_trans_model: PASS (64.29 s)
(6/6) type_specific.io-github-autotest-libvirt.memory.balloon.period.memory_allocation.int_period.virtio_non_trans_model: PASS (60.25 s)

chloerh · 2023-11-10T01:33:50Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+                time.sleep(5)
+            else:
+                usable_mem = re.findall(r'usable (\d+)', res)[0]
+                last_update = re.findall(r'last_update (\d+)', res)[0]


Would you consider wait_for()? Something like:

def func(): res = virsh.dommemstat(vm_name, ignore_status=False, debug=True).stdout_text return re.findall(r'usable (\d+)', res) is not None if not utils_misc.wait_for(func, 25, 5): return usable_mem = re.findall(r'usable (\d+)', res)[0] last_update = re.findall(r'last_update (\d+)', res)[0] disk_caches = re.findall(r'disk_caches (\d+)', res)[0] return xxxx

Also, what happened when we couldn't get the value we expect after 25s?

Thanks haijiao ,Sorry for late updating ,Updated as you said.

chloerh · 2023-11-10T01:37:07Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+            check_same_value(last_update_new, last_update, "last update")
+            check_same_value(disk_caches_new, disk_caches, "disk caches")
+
+        elif period_config.isdigit() and period_config.isdigit() != "0":


period_config != "0" ?

Thanks haijiao , Updated

chloerh · 2023-11-10T01:41:31Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        vmxml.del_device('memballoon', by_tag=True)
+        mem_balloon = memballoon.Memballoon()
+        mem_balloon.setup_attrs(**device_dict)
+        vmxml.devices = vmxml.devices.append(mem_balloon)
+
+        vmxml.setup_attrs(**mem_attrs)
+        vmxml.sync()


How about after removing memballoon device, we use libvirt_vmxml.modify_vm_device() to add new memballoon device, and maybe move vmxml.setup_attrs(**mem_attrs) to the front to avoid sync failure

Thanks haijiao , Updated :D

dzhengfy

Others LGTM

dzhengfy · 2023-11-30T08:29:15Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        test.log.info("TEST_STEP5: Do memory operation and check dommemstat")
+        session = vm.wait_for_login()
+        status, stdout = session.cmd_status_output(mem_operation)
+        session.close()


Do we need to repeat vm.wait_for_login() and session.close() ? Could we reuse a vm session in line 104?

Thanks dzheng, Done

dzhengfy · 2023-11-30T08:29:52Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        usable_mem_3, last_update_3, disk_caches_3 = get_memory_statistics()
+        session = vm.wait_for_login()
+        status, stdout = session.cmd_status_output(mem_operation)
+        session.close()


same as above

Thanks dzheng, Done

dzhengfy · 2023-11-30T08:32:55Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        Define and start guest
+        Check memTotal and memory allocation
+        """
+        test.log.info("TEST_STEP1: Define guest")


This is not accuate.

dzhengfy · 2023-11-30T08:34:29Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        test.log.info("TEST_STEP6: Change the period setting")
+        virsh.dommemstat(vm_name, period_cmd, ignore_status=False, debug=True)
+
+        test.log.info("TEST_STEP7: Repeat consume mem and check memory "


Is this log correct?

Thanks dzheng, Done

dzhengfy · 2023-12-03T09:18:38Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        usable_mem_1, last_update_1, disk_caches_1 = get_memory_statistics()
+
+        test.log.info("TEST_STEP5: Do memory operation and check dommemstat")
+        session = vm.wait_for_login()


Don't we reuse the session in line 104?

Thanks dzheng, updated, :D

dzhengfy · 2023-12-03T09:23:23Z

libvirt/tests/src/memory/memory_balloon/period_config_of_memory_balloon.py

+        test.log.info("TEST_STEP6: Change the period setting")
+        virsh.dommemstat(vm_name, period_cmd, ignore_status=False, debug=True)
+
+        test.log.info("TEST_STEP7: Repeat TEST_STEP3-5")


For below repeating steps 3-5, please wrap up the steps into another function instead of duplicating many codes.

Thanks dzheng, updated, :D

VIRT-299028: Period config of memory balloon Signed-off-by: nanli <[email protected]>

dzhengfy

LGTM

nanli1 force-pushed the add_case_for_period_config_of_mem_balloon branch 4 times, most recently from 07b51e8 to 27b0b7c Compare September 26, 2023 13:42

nanli1 marked this pull request as draft November 6, 2023 00:15

nanli1 marked this pull request as ready for review November 6, 2023 09:45

chloerh reviewed Nov 10, 2023

View reviewed changes

dzhengfy added the request_test_on_arm label Nov 15, 2023

nanli1 marked this pull request as draft November 17, 2023 02:00

nanli1 marked this pull request as ready for review November 19, 2023 01:21

nanli1 force-pushed the add_case_for_period_config_of_mem_balloon branch from 27b0b7c to 57d60fb Compare November 20, 2023 04:39

nanli1 requested a review from chloerh November 20, 2023 04:43

nanli1 force-pushed the add_case_for_period_config_of_mem_balloon branch from 57d60fb to 8336071 Compare November 20, 2023 04:43

dzhengfy reviewed Nov 30, 2023

View reviewed changes

nanli1 force-pushed the add_case_for_period_config_of_mem_balloon branch from 8336071 to 11231e6 Compare November 30, 2023 10:22

nanli1 requested a review from dzhengfy November 30, 2023 10:24

dzhengfy reviewed Dec 3, 2023

View reviewed changes

add case for period config of memballoon

f10246a

VIRT-299028: Period config of memory balloon Signed-off-by: nanli <[email protected]>

nanli1 force-pushed the add_case_for_period_config_of_mem_balloon branch from 11231e6 to f10246a Compare December 5, 2023 05:34

nanli1 requested a review from dzhengfy December 5, 2023 05:35

chloerh approved these changes Dec 13, 2023

View reviewed changes

dzhengfy approved these changes Dec 13, 2023

View reviewed changes

dzhengfy merged commit 02e1499 into autotest:master Dec 13, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add case for period config of memballoon #5206

add case for period config of memballoon #5206

nanli1 commented Sep 26, 2023 •

edited

Loading

chloerh Nov 10, 2023

chloerh Nov 10, 2023

nanli1 Nov 20, 2023

chloerh Nov 10, 2023

nanli1 Nov 20, 2023

chloerh Nov 10, 2023

nanli1 Nov 20, 2023

dzhengfy left a comment

dzhengfy Nov 30, 2023

nanli1 Nov 30, 2023

dzhengfy Nov 30, 2023

nanli1 Nov 30, 2023

dzhengfy Nov 30, 2023

dzhengfy Nov 30, 2023

nanli1 Nov 30, 2023

dzhengfy Dec 3, 2023

nanli1 Dec 5, 2023

dzhengfy Dec 3, 2023

nanli1 Dec 5, 2023

dzhengfy left a comment

add case for period config of memballoon #5206

add case for period config of memballoon #5206

Conversation

nanli1 commented Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dzhengfy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dzhengfy left a comment

Choose a reason for hiding this comment

nanli1 commented Sep 26, 2023 •

edited

Loading