Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve local variable 'res' referenced before assignment #5907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hholoubk
Copy link

Test was failing in case of coldplug + nondisk combination due missing property definiton.

For not hotplug will now start the VM in case of disk only if the disk attachment was successful. in case of other test_devices the VM should start

…g property definiton.

For not hotplug will now start the VM in case of disk only if the disk attachment was successful. in case of other test_devices the VM should start
@hholoubk
Copy link
Author

@smitterl could you please review the issue?

Copy link
Contributor

@chloerh chloerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hholoubk I have also opened a pr to fix this issue: #5881

@hholoubk
Copy link
Author

Oh .. great .. I am very new in this :D how to check if a solution already exists? so I didn't need to try to fix it

@chloerh
Copy link
Contributor

chloerh commented Sep 25, 2024

Oh .. great .. I am very new in this :D how to check if a solution already exists? so I didn't need to try to fix it

That's my fault. I should've logged work to the issue. You could check "worklog" to see if there's solution or not. But that's still not 100%...(depends on people)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants