Resolve test issue with aarch64 and 4k default hp size #5917
Conversation
|
@liang-cong-red-hat Could you help review it? |
|
@hholoubk As a general rule for a PR fixing a failure, could you please also provide below information in the comment?
|
| target_hugepages = 1024 | ||
| aarch64: | ||
| default_hp_size = 524288 |
There was a problem hiding this comment.
I think we could use vm (memory size) / ( default hugepage size) to get the target_hugepages number, just like the code did in python file. So param like default_hp_size and target_hugepages could be abandoned.
| if actual_hp_size != default_hp_size: | ||
| # actual hp size is different that is expected for defined number of hugepages | ||
| # as the size is not the main focus of the test, we have to recalculate and replace | ||
| new_target_hugepages = int((default_hp_size * target_hugepages) / actual_hp_size) |
There was a problem hiding this comment.
here we calculate the target hugepage number according to the actual hugepage size. As I mentioned before, we could directly use this way to calculate hugepage number we need.
There was a problem hiding this comment.
I let there the parameters, because I was not sure, if the desired size of huge pages (now it is 2048x1024) can depend on anything or can change in future. If the overall size is always same, it can be of course removed.
There was a problem hiding this comment.
you could get the memory size from domain xml, that is the total memory you want. you can use total memory / actual_hp_size, then you will get the huge page number.
…tual hp size and required VM memory. Therefore some configuration settings are no more necessary.
|
@liang-cong-red-hat Could you, please, review it again? thank you. I run the test manually, I will schedule it also via jenkins |
|
The PR is resolving issue with test:
|
Configuration of test for aarch64 expects 64k default hp size,, therefore test is not able to start the machine for 4k.