add basic nested hyperv on kvm test case #3723

lixuemin2016 · 2023-05-23T06:30:04Z

Signed-off-by: lixuemin2016 [email protected]

lixuemin2016 · 2023-05-23T06:51:00Z

Signed-off-by: lixuemin2016 [email protected]

qemu/deps/nested_hyperv/hyperv_env.ps1

peixiu · 2023-05-29T08:11:30Z

Tested on a host with Haswell CPU, it can be passed.

Tested with Win2019 guest os, commands as:
python3 ConfigTest.py --testcase=nested_hyperv_on_kvm --guestname=Win2019 --clone=yes

(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (1387.53 s)
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: STARTED
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: PASS (1053.16 s)

CPU flags as:
-cpu 'Haswell-noTSX',hv_reset,hv_crash,hv-no-nonarch-coresharing=auto,hv_emsr_bitmap,hv_evmcs,+vmx,hv_stimer,hv_synic,hv_vpindex,hv_relaxed,hv_spinlocks=0x1fff,hv_vapic,hv_time,hv_frequencies,hv_runtime,hv_tlbflush,hv_reenlightenment,hv_stimer_direct,hv_ipi,+kvm_pv_unhalt \

peixiu · 2023-05-29T08:23:17Z

@lixuemin2016 For commit log, you can add some description for this fix, It's more helpful for others to understand this patch~

lixuemin2016 · 2023-06-01T07:00:48Z

@lixuemin2016 For commit log, you can add some description for this fix, It's more helpful for others to understand this patch~

@peixiu thank you so much, Peixiu, updated with more descriptions in the commit log.

Start L1 Windows VM (w2022,2019,2016,win10)
Start L2 BIOS/UEFI VM via booting up fedora image

Test pass for win2022,2019,2016,win10 Gen1/Gen2 VM. For win11, after enable Hyper-V role in L1, it cannot boot up with cpu flags as below:
-cpu 'Haswell-noTSX',hv_reset,hv_crash,hv-no-nonarch-coresharing=auto,hv_emsr_bitmap,hv_evmcs,+vmx,hv_stimer,hv_synic,hv_vpindex,hv_relaxed,hv_spinlocks=0x1fff,hv_vapic,hv_time,hv_frequencies,hv_runtime,hv_tlbflush,hv_reenlightenment,hv_stimer_direct,hv_ipi,+kvm_pv_unhalt \

lixuemin2016 · 2023-06-01T07:02:03Z

close by mistake :)

lixuemin2016 · 2023-06-01T08:29:08Z

Test result for w2022 for example:
./ConfigTest.py --testcase=nested_hyperv_on_kvm.q35 --guestname=Win2022 --platform=x86_64 --machines=q35

JOB LOG : /root/avocado/job-results/job-2023-06-01T14.34-63165d4/job.log
(1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (1529.38 s)
(2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: STARTED
(2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: PASS (831.57 s)
(3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: STARTED
(3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.nested_hyperv_on_kvm.q35: PASS (501.29 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado/job-results/job-2023-06-01T14.34-63165d4/results.html

lixuemin2016 · 2023-06-01T08:32:11Z

@YongxueHong Could you please help to review this PR? Thank you so much.

YongxueHong · 2023-06-02T01:32:33Z

qemu/tests/cfg/nested_hyperv_on_kvm.cfg

@@ -0,0 +1,16 @@
+- nested_hyperv_on_kvm:
+    type = nested_hyperv_on_kvm
+    download_url = "https://fedora.mirror.constant.com/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2"


Suggested change

download_url = "https://fedora.mirror.constant.com/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2"

download_url = ""

It looks like this link is a private site we can not expose it in public.

Yes, changed. Thank you for reminder. Even this URL can be accessed from public.

@YongxueHong Hi Yongxue,

Thank you so much for your review and reminder, all the suggestions have been updated.

Best Regards,
Xuemin

qemu/tests/nested_hyperv_on_kvm.py

qemu/tests/cfg/nested_hyperv_on_kvm.cfg

YongxueHong · 2023-06-02T02:03:39Z

Hi, @lixuemin2016
For the commit signed-off: Signed-off-by: root <[email protected]>, please update the root to your name, thanks.

lixuemin2016 · 2023-07-05T01:49:12Z

@PaulYuuu, @YongxueHong

Hi Yihuang, Yongxue,

I have updated this PR based on Yongxue's suggestion.

Could you please help to take a look again at this PR when you get time?
Thank you so much.

Best Regards,
Xuemin

PaulYuuu · 2023-07-06T01:58:16Z

qemu/tests/nested_hyperv_on_kvm.py

+    get_vhdx()
+
+    need_reboot = 0
+    status, output = session.cmd_status_output("powershell Get-VM \


Suggested change

status, output = session.cmd_status_output("powershell Get-VM \

status = session.cmd_status("powershell Get-VM \

@PaulYuuu Updated, thank you so much for your comment.

PaulYuuu · 2023-07-06T01:59:49Z

qemu/tests/nested_hyperv_on_kvm.py

+    hyperv_source = os.path.join(data_dir.get_deps_dir(), "nested_hyperv")
+    vm.copy_files_to(hyperv_source, nested_dest)
+
+    # set ExecutionPolicy mainly for winows 11


Check Win version first?

@PaulYuuu
Thank you so much for review.
Change the description to "set RemoteSigned policy mainly for windows 10/11, it is default for windows server". This powershell command "Set-ExecutionPolicy" can be executed to windows server (2016/2019/2022), and windows 10/11.

For windows server 2016/2019/2022, the default policy is 'RemoteSigned', after execute the command, it does not have side effect. For windows 10/11, the default is undefined, so must execute this command.

==============================================================================
Refer to https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_execution_policies?view=powershell-7.3.

RemoteSigned
The default execution policy for Windows server computers.

Undefined
There is no execution policy set in the current scope.
If the execution policy in all scopes is Undefined, the effective execution policy is Restricted for Windows clients and RemoteSigned for Windows Server.

Thank you so much.
Xuemin

PaulYuuu · 2023-07-06T02:04:36Z

qemu/tests/cfg/nested_hyperv_on_kvm.cfg

@@ -0,0 +1,15 @@
+- nested_hyperv_on_kvm:


Consider only x86_64 and only Windows

Updated, thank you so much for your comment @PaulYuuu

1. Start L1 Windows VM (w2022,2019,2016,win10) 2. Start L2 BIOS/UEFI VM via booting up fedora image ID: 2219365 Signed-off-by: xuemin <[email protected]>

YongxueHong · 2023-06-09T06:39:16Z

qemu/tests/nested_hyperv_on_kvm.py

+import time
+import os
+from avocado.utils import download
+from avocado.utils import process
+from virttest import data_dir
+from virttest import error_context


Suggested change

import time

import os

from avocado.utils import download

from avocado.utils import process

from virttest import data_dir

from virttest import error_context

import time

import os

from avocado.utils import download

from avocado.utils import process

from virttest import data_dir

from virttest import error_context

YongxueHong

LGTM.

lixuemin2016 commented May 23, 2023

View reviewed changes

qemu/deps/nested_hyperv/hyperv_env.ps1 Show resolved Hide resolved

lixuemin2016 force-pushed the new_nested branch 5 times, most recently from ef9b698 to 6725efa Compare May 23, 2023 07:17

lixuemin2016 force-pushed the new_nested branch from 8bf0241 to e7a88e7 Compare June 1, 2023 06:21

lixuemin2016 closed this Jun 1, 2023

lixuemin2016 reopened this Jun 1, 2023

YongxueHong reviewed Jun 2, 2023

View reviewed changes

lixuemin2016 force-pushed the new_nested branch 6 times, most recently from 6f7fb53 to 51b2323 Compare June 5, 2023 06:43

lixuemin2016 force-pushed the new_nested branch from 51b2323 to 0a8ae21 Compare July 3, 2023 12:48

PaulYuuu reviewed Jul 6, 2023

View reviewed changes

lixuemin2016 force-pushed the new_nested branch from 0a8ae21 to f5d6862 Compare July 6, 2023 03:53

Add basic nested hyperv on kvm test case

a49d408

1. Start L1 Windows VM (w2022,2019,2016,win10) 2. Start L2 BIOS/UEFI VM via booting up fedora image ID: 2219365 Signed-off-by: xuemin <[email protected]>

lixuemin2016 force-pushed the new_nested branch from f5d6862 to a49d408 Compare July 6, 2023 04:09

PaulYuuu approved these changes Jul 11, 2023

View reviewed changes

YongxueHong reviewed Jul 11, 2023

View reviewed changes

YongxueHong approved these changes Jul 11, 2023

View reviewed changes

YongxueHong merged commit 3650d38 into autotest:master Jul 11, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add basic nested hyperv on kvm test case #3723

add basic nested hyperv on kvm test case #3723

lixuemin2016 commented May 23, 2023 •

edited

Loading

lixuemin2016 commented May 23, 2023

peixiu commented May 29, 2023

peixiu commented May 29, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

YongxueHong Jun 2, 2023

lixuemin2016 Jun 5, 2023 •

edited

Loading

lixuemin2016 Jun 5, 2023 •

edited

Loading

YongxueHong commented Jun 2, 2023 •

edited

Loading

lixuemin2016 commented Jul 5, 2023

PaulYuuu Jul 6, 2023

lixuemin2016 Jul 6, 2023 •

edited

Loading

PaulYuuu Jul 6, 2023

lixuemin2016 Jul 6, 2023 •

edited

Loading

PaulYuuu Jul 6, 2023

lixuemin2016 Jul 6, 2023

YongxueHong Jun 9, 2023

YongxueHong left a comment

	download_url = "https://fedora.mirror.constant.com/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2"
	download_url = ""

	status, output = session.cmd_status_output("powershell Get-VM \
	status = session.cmd_status("powershell Get-VM \

add basic nested hyperv on kvm test case #3723

add basic nested hyperv on kvm test case #3723

Conversation

lixuemin2016 commented May 23, 2023 • edited Loading

lixuemin2016 commented May 23, 2023

peixiu commented May 29, 2023

peixiu commented May 29, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

lixuemin2016 commented Jun 1, 2023

YongxueHong Jun 2, 2023

Choose a reason for hiding this comment

lixuemin2016 Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

lixuemin2016 Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

YongxueHong commented Jun 2, 2023 • edited Loading

lixuemin2016 commented Jul 5, 2023

PaulYuuu Jul 6, 2023

Choose a reason for hiding this comment

lixuemin2016 Jul 6, 2023 • edited Loading

Choose a reason for hiding this comment

PaulYuuu Jul 6, 2023

Choose a reason for hiding this comment

lixuemin2016 Jul 6, 2023 • edited Loading

Choose a reason for hiding this comment

PaulYuuu Jul 6, 2023

Choose a reason for hiding this comment

lixuemin2016 Jul 6, 2023

Choose a reason for hiding this comment

YongxueHong Jun 9, 2023

Choose a reason for hiding this comment

YongxueHong left a comment

Choose a reason for hiding this comment

lixuemin2016 commented May 23, 2023 •

edited

Loading

lixuemin2016 Jun 5, 2023 •

edited

Loading

lixuemin2016 Jun 5, 2023 •

edited

Loading

YongxueHong commented Jun 2, 2023 •

edited

Loading

lixuemin2016 Jul 6, 2023 •

edited

Loading

lixuemin2016 Jul 6, 2023 •

edited

Loading