Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numa_negative.threads_test: includes test_negative_thread cfg param #3758

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

mcasquer
Copy link
Contributor

numa_negative.threads_test: includes test_negative_thread cfg param

Include the test_negative_thread configuration param to avoid
setting the number of vcpu_threads to 1 in qemu_vm avocado-vt.

ID: 2217797
Signed-off-by: mcasquer [email protected]

Include the test_negative_thread configuration param to avoid
setting the number of vcpu_threads to 1 in qemu_vm avocado-vt.

Signed-off-by: mcasquer <[email protected]>
@mcasquer
Copy link
Contributor Author

After applying the patch, the case pass as expected

 (1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.numa_negative.threads_test.q35: STARTED
 (1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.numa_negative.threads_test.q35: PASS (24.34 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

The following log traces could be observed in the debug.log

[stdlog] 2023-06-27 02:57:52,440 avocado.virttest.qemu_vm INFO | [qemu output] qemu-kvm: warning: This family of AMD CPU doesn't support hyperthreading(2)
[stdlog] 2023-06-27 02:57:52,440 avocado.virttest.qemu_vm INFO | [qemu output] Please configure -smp options properly or try enabling topoext feature.

@mcasquer mcasquer marked this pull request as ready for review June 27, 2023 07:03
@mcasquer
Copy link
Contributor Author

@PaulYuuu @yanan-fu @nanliu-r could you review this PR? Thanks!

@PaulYuuu PaulYuuu requested a review from yanan-fu June 27, 2023 07:41
@nanliu-r
Copy link
Contributor

@mcasquer Is this case x86 platform only?

@mcasquer
Copy link
Contributor Author

@mcasquer Is this case x86 platform only?

No, it seems it's supported by others.
FYI @zhenyzha @MiriamDeng @fbq815

@fbq815
Copy link
Contributor

fbq815 commented Jun 27, 2023

Test result on s390x:
JOB ID : 7cac5edb0b913b423dfd0702ea059701f20800df
JOB LOG : /root/avocado/job-results/job-2023-06-27T05.28-7cac5ed/job.log
(1/2) Host_RHEL.m9.u3.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.s390x.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.s390-virtio: STARTED
(1/2) Host_RHEL.m9.u3.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.s390x.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.s390-virtio: PASS (421.88 s)
(2/2) Host_RHEL.m9.u3.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.s390x.io-github-autotest-qemu.numa_negative.threads_test.s390-virtio: STARTED
(2/2) Host_RHEL.m9.u3.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.s390x.io-github-autotest-qemu.numa_negative.threads_test.s390-virtio: PASS (4.94 s)
RESULTS : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado/job-results/job-2023-06-27T05.28-7cac5ed/results.html
JOB TIME : 428.37 s

@MiriamDeng
Copy link
Contributor

MiriamDeng commented Jun 30, 2023

LGTM
(1/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads: STARTED
(1/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads: PASS (1235.73 s)
(2/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.ppc64le.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads: STARTED
(2/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.ppc64le.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads: PASS (1086.09 s)
(3/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.numa_negative.threads_test: STARTED
(3/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.ppc64le.io-github-autotest-qemu.numa_negative.threads_test: PASS (6.14 s)
(4/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.ppc64le.io-github-autotest-qemu.numa_negative.threads_test: STARTED
(4/4) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.ppc64le.io-github-autotest-qemu.numa_negative.threads_test: PASS (6.31 s)

@zhenyzha
Copy link
Contributor

zhenyzha commented Jul 1, 2023

LGTM.Acked-by: Zhenyu Zhang [email protected]

 (1/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.threads_test.arm64-pci: STARTED
 (1/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.threads_test.arm64-pci: PASS (8.90 s)
 (2/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.mem_mismatch.arm64-pci: STARTED
 (2/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.mem_mismatch.arm64-pci: PASS (5.96 s)
 (3/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.cpu_mismatch.arm64-pci: STARTED
 (3/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.cpu_mismatch.arm64-pci: PASS (8.95 s)
 (4/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.nodeid_mismatch.arm64-pci: STARTED
 (4/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.nodeid_mismatch.arm64-pci: PASS (6.06 s)
 (5/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.mem_zero.arm64-pci: STARTED
 (5/5) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.numa_negative.mem_zero.arm64-pci: PASS (9.05 s)

@mcasquer
Copy link
Contributor Author

mcasquer commented Jul 3, 2023

Tests results have been provided from all memory feature owners, could this PR be merged? Thanks!

Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to clarify that test_negative_thread only for AMD, but will be handled at vt part.

        if amd_vendor_string == cpu.get_cpu_vendor():
            # AMD cpu do not support multi threads besides EPYC
            if (params.get("test_negative_thread", "no") != "yes" and
                    not cpu_model.startswith('EPYC')):
                vcpu_threads = 1
                txt = "Set vcpu_threads to 1 for AMD non-EPYC cpu."
                LOG.warn(txt)

@PaulYuuu PaulYuuu merged commit 891e9ec into autotest:master Jul 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants