-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numa_negative.threads_test: includes test_negative_thread cfg param #3758
numa_negative.threads_test: includes test_negative_thread cfg param #3758
Conversation
Include the test_negative_thread configuration param to avoid setting the number of vcpu_threads to 1 in qemu_vm avocado-vt. Signed-off-by: mcasquer <[email protected]>
After applying the patch, the case pass as expected (1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.numa_negative.threads_test.q35: STARTED
(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.numa_negative.threads_test.q35: PASS (24.34 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 The following log traces could be observed in the debug.log [stdlog] 2023-06-27 02:57:52,440 avocado.virttest.qemu_vm INFO | [qemu output] qemu-kvm: warning: This family of AMD CPU doesn't support hyperthreading(2)
[stdlog] 2023-06-27 02:57:52,440 avocado.virttest.qemu_vm INFO | [qemu output] Please configure -smp options properly or try enabling topoext feature. |
@mcasquer Is this case x86 platform only? |
No, it seems it's supported by others. |
Test result on s390x: |
LGTM |
LGTM.Acked-by: Zhenyu Zhang [email protected]
|
Tests results have been provided from all memory feature owners, could this PR be merged? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to clarify that test_negative_thread
only for AMD, but will be handled at vt part.
if amd_vendor_string == cpu.get_cpu_vendor():
# AMD cpu do not support multi threads besides EPYC
if (params.get("test_negative_thread", "no") != "yes" and
not cpu_model.startswith('EPYC')):
vcpu_threads = 1
txt = "Set vcpu_threads to 1 for AMD non-EPYC cpu."
LOG.warn(txt)
numa_negative.threads_test: includes test_negative_thread cfg param
Include the test_negative_thread configuration param to avoid
setting the number of vcpu_threads to 1 in qemu_vm avocado-vt.
ID: 2217797
Signed-off-by: mcasquer [email protected]