Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passt stability tests #4062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

passt stability tests #4062

wants to merge 1 commit into from

Conversation

yanglei-rh
Copy link
Contributor

Add a new case to support passt stability tests.

ID:2445
Signed-off-by: Lei Yang [email protected]

@yanglei-rh
Copy link
Contributor Author

Hello @PaulYuuu @fbq815 @zhenyzha Could you please help me review this patch when you have free time? Thanks a lot.

@zhenyzha
Copy link
Contributor

Hit error:
avocado.core.exceptions.TestError: Could not find test file passt_stability_tests.py on testdirs ['/home/kar/workspace/root/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-qemu/generic/deps/clock_getres',

@yanglei-rh
Copy link
Contributor Author

Hit error: avocado.core.exceptions.TestError: Could not find test file passt_stability_tests.py on testdirs ['/home/kar/workspace/root/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-qemu/generic/deps/clock_getres',

Sorry for the replay later, this problem has been fixed. Please help review it again if you have free time.

@fbq815
Copy link
Contributor

fbq815 commented Jul 16, 2024

test got failed on s390x and I've paste the log in jira issue

@yanglei-rh
Copy link
Contributor Author

test got failed on s390x and I've paste the log in jira issue

Hi @fbq815 First, thanks for your help review, but according to you test log you are still using the tap device instead of passt, so test failed. I will write a test steps for this ASAP, please help review it again that time. Thanks a lot.

@yanglei-rh
Copy link
Contributor Author

Hi @zhenyzha @fbq815 @PaulYuuu Please help review it again, thanks a lot. For the test steps please review the automation bug.

@yanglei-rh
Copy link
Contributor Author

Hi @zhenyzha @fbq815 @PaulYuuu Please help review it again, thanks a lot. For the test steps please review the automation bug.

Hello All, any update for this patch?

Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't see any code related to passt, and almost code are copied from iperf test.

qemu/tests/cfg/passt_stability_test.cfg Outdated Show resolved Hide resolved
@yanglei-rh
Copy link
Contributor Author

Hi @PaulYuuu Could you please help review this patch again? Thanks a lot.

@PaulYuuu
Copy link
Contributor

I don't see you fix the problem, please double-check.

@yanglei-rh
Copy link
Contributor Author

Actually, I don't see any code related to passt, and almost code are copied from iperf test.

Let me reply this question on the patch which like we disscuss it offline in the past. Due passt only as a network backend, so for tests only forcus on the different iperf parameters and transfer method for iperf source package. The steps for compiling iperf and running the test are indeed copied from the iperf test, there are two reasons: first and most important, we can't just write a cfg and reuse the iperf test python file directly that would make the original file unrecognizable. , because this is limited by the usage of passt. The second point is also related to the first point. Writing a new one directly will make the automation complete quickly because it will not affect others and will facilitate future maintenance.

@yanglei-rh
Copy link
Contributor Author

I don't see you fix the problem, please double-check.

For now, I think I fixed all problems, so please help review it again. Thanks a lot.

Add a new case to support passt stability tests.

Signed-off-by: Lei Yang <[email protected]>
@yanglei-rh
Copy link
Contributor Author

yanglei-rh commented Sep 5, 2024

Hi @PaulYuuu Please help me review this patch again, thanks a lot. It can test pass on my side.

@PaulYuuu
Copy link
Contributor

Hello @fbq815, any comment for the latest update?

Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
qemu.passt_stability_tests.with_tcp.s390-virtio: PASS (257.80 s)
qemu.passt_stability_tests.with_udp.s390-virtio: PASS (248.59 s)

test.error("Failed to start iperf session")
else:
test.log.debug("Full connection server log:\n%s", server_output)
print(server_output)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't think we need the print func.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants