Netkvm: use WinDump for capture and Wireshark for analysis #4097

heywji · 2024-07-05T08:46:58Z

Replace tshark.exe with WinDump.exe for capturing network traffic. This resolves the issue where enabling netkvm driver TxLSO results in no packet length >= 1514 after file transfer, identified as a Wireshark problem.

ID: 2395
Signed-off-by: wji [email protected]

heywji · 2024-07-05T08:50:45Z

Test Result:

 (1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: PASS (499.27 s)

heywji · 2024-07-05T08:52:51Z

Hi @leidwang and @yanglei-rh,

Could you guys help me review this patch when you are free? Thanks in advance.

yanglei-rh · 2024-07-08T09:45:08Z

Please re-write the test steps, the whole process is not installed tshark.exe, but you use it to parse the final result, which will cause failure due to the lack of this file. You provide test result is not correct, please reinstall windows guest and test it again, then you will hit I mentioned problem.
In the future, please follow the steps below when providing your test results: clear your env, then apply patch and provide test result. Instead of provide test result based on your develop env.

heywji · 2024-07-08T13:31:53Z

Hi @yanglei-rh,

Thanks for your advice. I will provide the whole test cases which include unattended_install and the case that I want to test.

 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (1615.65 s)
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: STARTED
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: PASS (502.66 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /root/avocado/job-results/job-2024-07-08T18.07-70ef483/results.html
JOB TIME   : 2121.74 s

For this patch, I have installed the tshark.exe with the /S parameter with line 20. You know, the Wireshark installer supports the /S parameter for silent installation on Windows.

qemu/tests/cfg/enable_scatter_windows.cfg

leidwang · 2024-07-09T01:20:32Z

qemu/tests/cfg/enable_scatter_windows.cfg

    x86_64:
        wireshark_name = "Wireshark-win64-1.10.1.exe"
    i386, i686:
        wireshark_name = "Wireshark-win32-1.10.1.exe"
-    install_wireshark_cmd = "xcopy WIN_UTILS:\${wireshark_name} c:\ /y && c:\${wireshark_name} /S"
+    installation_cmd = "xcopy WIN_UTILS:\${WinDump_name} c:\ /y  && xcopy WIN_UTILS:\${wireshark_name} c:\ /y && c:\${wireshark_name} /S"


Seems this cmd will copy windump and wireshark to C and then install wireshark, is this expected?

As the title of this PR says: "Netkvm: Replace tshark.exe with WinDump.exe".
Why does your code still install wireshark but not windump?

At the end of this case, we still need to analyze the packet's result with Wireshark only. However, we have used Windump to capture NetFlow data since Wireshark has a bug.

For the WinDump part, WinDump.exe is a portable software that does not need to be installed.

Thank @leidwang and let me think about the patch title again : )

yanglei-rh · 2024-07-09T01:39:17Z

Hi @yanglei-rh,

Thanks for your advice. I will provide the whole test cases which include unattended_install and the case that I want to test.

 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (1615.65 s)
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: STARTED
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.WinNext.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: PASS (502.66 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /root/avocado/job-results/job-2024-07-08T18.07-70ef483/results.html
JOB TIME   : 2121.74 s

For this patch, I have installed the tshark.exe with the /S parameter with line 20. You know, the Wireshark installer supports the /S parameter for silent installation on Windows.

But what confuses me is that it always failed with " avocado.core.exceptions.TestError: Failed to parse session log file, status=9009, output='"C:\Program Files\Wireshark\tshark.exe"' is not recognized as an internal or external command," on my side, why you can test pass? Could you please try to test it again with other guest? Such as Win11 or Win2025, or both two.

heywji · 2024-07-09T01:44:50Z

Thanks, guys. Let me do more tests.

leidwang · 2024-07-24T02:12:07Z

Hi @heywji Please mark this PR as draft status if it is not ready to review,thanks.

Replace tshark.exe with WinDump.exe for capturing network traffic. This resolves the issue where enabling netkvm driver TxLSO results in no packet length >= 1514 after file transfer, identified as a Wireshark problem. Signed-off-by: wji <[email protected]>

heywji · 2024-09-24T09:54:18Z

Hi @yanglei-rh @leidwang, Could you guys help review it again since everything works well now?

Test result:

 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (876.53 s)
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: STARTED
 (2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.enable_scatter_windows.q35: PASS (401.36 s)

leidwang reviewed Jul 9, 2024

View reviewed changes

heywji marked this pull request as draft July 24, 2024 04:51

heywji force-pushed the change_to_tshark branch from a64cc14 to a1850ec Compare September 14, 2024 03:10

heywji marked this pull request as ready for review September 14, 2024 04:12

heywji force-pushed the change_to_tshark branch 2 times, most recently from 1901e8d to 857bfcd Compare September 15, 2024 02:33

heywji marked this pull request as draft September 24, 2024 03:40

heywji force-pushed the change_to_tshark branch from 857bfcd to 9d784a3 Compare September 24, 2024 08:03

heywji changed the title ~~Netkvm: replace tshark.exe with WinDump.exe~~ Netkvm: use WinDump for capture and Wireshark for analysis Sep 24, 2024

heywji force-pushed the change_to_tshark branch from 9d784a3 to e7fce8b Compare September 24, 2024 09:13

heywji marked this pull request as ready for review September 24, 2024 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Netkvm: use WinDump for capture and Wireshark for analysis #4097

Netkvm: use WinDump for capture and Wireshark for analysis #4097

heywji commented Jul 5, 2024

heywji commented Jul 5, 2024

heywji commented Jul 5, 2024

yanglei-rh commented Jul 8, 2024

heywji commented Jul 8, 2024

leidwang Jul 9, 2024

heywji Jul 9, 2024

leidwang Jul 9, 2024

heywji Jul 9, 2024

heywji Jul 9, 2024

yanglei-rh commented Jul 9, 2024

heywji commented Jul 9, 2024

leidwang commented Jul 24, 2024

heywji commented Sep 24, 2024

Netkvm: use WinDump for capture and Wireshark for analysis #4097

Are you sure you want to change the base?

Netkvm: use WinDump for capture and Wireshark for analysis #4097

Conversation

heywji commented Jul 5, 2024

heywji commented Jul 5, 2024

heywji commented Jul 5, 2024

yanglei-rh commented Jul 8, 2024

heywji commented Jul 8, 2024

leidwang Jul 9, 2024

Choose a reason for hiding this comment

heywji Jul 9, 2024

Choose a reason for hiding this comment

leidwang Jul 9, 2024

Choose a reason for hiding this comment

heywji Jul 9, 2024

Choose a reason for hiding this comment

heywji Jul 9, 2024

Choose a reason for hiding this comment

yanglei-rh commented Jul 9, 2024

heywji commented Jul 9, 2024

leidwang commented Jul 24, 2024

heywji commented Sep 24, 2024