Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockdev_commit_backing_mask_on:test backing_mask on #4144

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

aliang123
Copy link
Contributor

When doing commit with backing_mask_protocol on,
the backing raw image format can be identified
correctly as "raw" for "raw format blockdev
elimination".

id:2808

@aliang123
Copy link
Contributor Author

(1/1) Host_RHEL.m9.ux.ovmf.nbd.raw.virtio_scsi.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.blockdev_commit_backing_mask_on.q35: PASS (107.54 s)

details:
{"execute": "block-commit", "arguments": {"base-node": "drive_data", "top-node": "drive_sn3", "backing-mask-protocol": true, "device": "drive_sn4", "job-id": "drive_sn4_RCUg"}, "id": "m5j2cgQT"}

#qemu-img info -U /root/avocado/data/avocado-vt/sn4.qcow2 --output=human
file format: qcow2
virtual size: 2 GiB (2147483648 bytes)
disk size: 11 MiB
cluster_size: 65536
backing file: nbd://10.72.140.40:10831
backing file format: raw

@aliang123
Copy link
Contributor Author

@zhencliu @XueqiangWei @maxujun , please help review it, thanks.

@maxujun
Copy link
Contributor

maxujun commented Sep 3, 2024

(1/1) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.blockdev_commit_backing_mask_on: STARTED
(1/1) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.blockdev_commit_backing_mask_on: CANCEL: Got host qemu version:6.2.0-52, which is not in [9.0.0,) (2.95 s)

Not support from ppc side. LGTM.

When doing commit with backing_mask_protocol on,
the backing raw image format can be identified
correctly as "raw" for "raw format blockdev
elimination".

Signed-off-by: Aihua Liang <[email protected]>
Copy link
Contributor

@XueqiangWei XueqiangWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Acked-by: [email protected]

@XueqiangWei XueqiangWei merged commit 4cc64ef into autotest:master Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants