Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Badge bit masking #59

Open
jonlamb-gh opened this issue Sep 26, 2019 · 1 comment
Open

Fix Badge bit masking #59

jonlamb-gh opened this issue Sep 26, 2019 · 1 comment

Comments

@jonlamb-gh
Copy link
Contributor

The implementation of Badge::are_all_overlapping_bits_set() should be updated to reflect the masking behavior it's used for, instead of returning true if any bits overlap.
@ZackPierce
Copy link
Contributor

Seems like a good all vs any sort of distinction to make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZackPierce @jonlamb-gh