avoid text file busy error on track #2494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
sukantoraymond,
arturrez and
meaghanfitzgerald
| } | ||
| if err := os.Chmod(pluginPath, constants.DefaultPerms755); err != nil { | ||
| return err | ||
| if !utils.IsExecutable(pluginPath) { |
There was a problem hiding this comment.
Should we be checking if the file exists before creating a new copy, and then checking if it's not already executable before doing the chmod?
There was a problem hiding this comment.
If the file exists and is not executable it is sign of a problem in the previous setup. It can be a partial copy for
example. So probably it is best to copy it again.
Also, if it is not executable, there is not risk of encountering text file busy error during copy
because that happens when the binary is being executed.
There was a problem hiding this comment.
Gotcha, could you add a comment explaining that context here? 🙏
| } | ||
| if err := os.Chmod(pluginPath, constants.DefaultPerms755); err != nil { | ||
| return err | ||
| if !utils.IsExecutable(pluginPath) { |
There was a problem hiding this comment.
Can we make a unit for these code paths?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #2465
How this works
How this was tested
How is this documented