-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include optional footer for commit range #14
Comments
@JakeGinnivan do you think that |
I am interested in the commit hashes for https://github.com/JakeGinnivan/GitReleaseNotes It is useful for appending new items to the release notes |
👍 for this, the commit hashes could be recognize as footer. |
Seems a reasonable request to me. Wondering if there are other sorts of metadata that would come out similar to this... just wondering if its worth considering them together? As in, there is a formal concept of "footer metadata" which is made up of known key/value pairs like |
Great idea! |
Thanks what I was thinking. Anyone else think of anything? |
Maybe download links to source/zip etc? |
Something like this?
|
Additional thought, it can be handy to include the checksum of the files:
What do you think? |
Sounds good. The checksum should be optional. Is it just the keys we are enforcing right? Or do we enforce the structure? |
Yes, checksum is optional. |
Just thought of another, |
Something like this?
|
Yep, I tend to do |
Yeah, I think this one should not have to be checked on the value side. |
Thinking through generating/updates existing release notes a So basically, I think we need
I think that should do it for now :P |
All right, another good thought. |
Do we think these metadata "titles"/keys need to be namespace? Like:
|
Personally I don't see the point, the metada are linked to one release so I don't think it can be a problem. But I might missing something. @JakeGinnivan concerning |
Lets just follow http://en.wikipedia.org/wiki/ISO_8601 Should we use UTC so |
I have preference for UTC but since right now you are the only user of this metadata, what is the best for you? 😄 |
Don't really care. It is a tool which is going to use this to append new items to an existing release. |
So let's say we use UTC. |
Yep 👍 |
I'm good with that format and UTC sounds good. Regarding namespaces, guess I'm wanting to make sure that we don't shoot ourselves in the foot. |
I would like to have under the issues list something like this:
Commits: b0ef2eb...62e4c21
or
Commits: [b0ef2eb...62e4c21](diffurl)
The text was updated successfully, but these errors were encountered: