From e8d2bec1587d5858533a6b7885c899f2dc8fbd5f Mon Sep 17 00:00:00 2001 From: Aman Bahuguna Date: Thu, 23 Jan 2025 16:45:44 +0530 Subject: [PATCH] removed grade from enrollment record --- lib/dbservice/enrollment_record/enrollment_record.ex | 3 --- lib/dbservice/enrollment_records.ex | 2 -- .../controllers/enrollment_record_controller.ex | 1 - lib/dbservice_web/controllers/group_user_controller.ex | 1 - lib/dbservice_web/swagger_schemas/enrollment_record.ex | 2 -- lib/dbservice_web/views/enrollment_record_view.ex | 1 - .../20250123110317_remove_grade_id_from_grade.exs | 9 +++++++++ 7 files changed, 9 insertions(+), 10 deletions(-) create mode 100644 priv/repo/migrations/20250123110317_remove_grade_id_from_grade.exs diff --git a/lib/dbservice/enrollment_record/enrollment_record.ex b/lib/dbservice/enrollment_record/enrollment_record.ex index 10d25e0c..41cb5895 100644 --- a/lib/dbservice/enrollment_record/enrollment_record.ex +++ b/lib/dbservice/enrollment_record/enrollment_record.ex @@ -6,7 +6,6 @@ defmodule Dbservice.EnrollmentRecords.EnrollmentRecord do import Dbservice.Utils.Util alias Dbservice.Users.User - alias Dbservice.Grades.Grade alias Dbservice.Subjects.Subject schema "enrollment_record" do @@ -17,7 +16,6 @@ defmodule Dbservice.EnrollmentRecords.EnrollmentRecord do field :group_id, :integer field :group_type, :string - belongs_to(:grade, Grade) belongs_to(:subject, Subject) belongs_to(:user, User) @@ -47,7 +45,6 @@ defmodule Dbservice.EnrollmentRecords.EnrollmentRecord do :academic_year, :group_id, :group_type, - :grade_id, :subject_id ]) |> validate_required(required_fields) diff --git a/lib/dbservice/enrollment_records.ex b/lib/dbservice/enrollment_records.ex index 2e2cfa9b..a2a7d6a3 100644 --- a/lib/dbservice/enrollment_records.ex +++ b/lib/dbservice/enrollment_records.ex @@ -69,14 +69,12 @@ defmodule Dbservice.EnrollmentRecords do user_id, group_id, group_type, - grade_id, academic_year ) do Repo.get_by(EnrollmentRecord, user_id: user_id, group_id: group_id, group_type: group_type, - grade_id: grade_id, academic_year: academic_year ) end diff --git a/lib/dbservice_web/controllers/enrollment_record_controller.ex b/lib/dbservice_web/controllers/enrollment_record_controller.ex index b181e9ca..6290b30f 100644 --- a/lib/dbservice_web/controllers/enrollment_record_controller.ex +++ b/lib/dbservice_web/controllers/enrollment_record_controller.ex @@ -78,7 +78,6 @@ defmodule DbserviceWeb.EnrollmentRecordController do params["user_id"], params["group_id"], params["group_type"], - params["grade_id"], params["academic_year"] ) do nil -> diff --git a/lib/dbservice_web/controllers/group_user_controller.ex b/lib/dbservice_web/controllers/group_user_controller.ex index ae4aa1fd..06b02f41 100644 --- a/lib/dbservice_web/controllers/group_user_controller.ex +++ b/lib/dbservice_web/controllers/group_user_controller.ex @@ -238,7 +238,6 @@ defmodule DbserviceWeb.GroupUserController do "group_id" => group.child_id, "group_type" => group.type, "user_id" => params["user_id"], - "grade_id" => params["grade_id"], "academic_year" => academic_year, "start_date" => params["start_date"] } diff --git a/lib/dbservice_web/swagger_schemas/enrollment_record.ex b/lib/dbservice_web/swagger_schemas/enrollment_record.ex index 34909f98..804d5d97 100644 --- a/lib/dbservice_web/swagger_schemas/enrollment_record.ex +++ b/lib/dbservice_web/swagger_schemas/enrollment_record.ex @@ -11,7 +11,6 @@ defmodule DbserviceWeb.SwaggerSchema.EnrollmentRecord do description("An enrollment record for the student") properties do - grade(:string, "Grade") academic_year(:string, "Academic Year") is_current(:boolean, "Is current enrollment record for student") student_id(:integer, "Student ID that the program enrollment belongs to") @@ -22,7 +21,6 @@ defmodule DbserviceWeb.SwaggerSchema.EnrollmentRecord do end example(%{ - grade: "7", academic_year: "2022", is_current: true, student_id: 1, diff --git a/lib/dbservice_web/views/enrollment_record_view.ex b/lib/dbservice_web/views/enrollment_record_view.ex index 0a45c620..a3708f94 100644 --- a/lib/dbservice_web/views/enrollment_record_view.ex +++ b/lib/dbservice_web/views/enrollment_record_view.ex @@ -20,7 +20,6 @@ defmodule DbserviceWeb.EnrollmentRecordView do group_id: enrollment_record.group_id, group_type: enrollment_record.group_type, user_id: enrollment_record.user_id, - grade_id: enrollment_record.grade_id, subject_id: enrollment_record.subject_id } end diff --git a/priv/repo/migrations/20250123110317_remove_grade_id_from_grade.exs b/priv/repo/migrations/20250123110317_remove_grade_id_from_grade.exs new file mode 100644 index 00000000..7301e754 --- /dev/null +++ b/priv/repo/migrations/20250123110317_remove_grade_id_from_grade.exs @@ -0,0 +1,9 @@ +defmodule Dbservice.Repo.Migrations.RemoveGradeIdFromGrade do + use Ecto.Migration + + def change do + alter table(:enrollment_record) do + remove :grade_id + end + end +end