From 72023b8a62ed15ba26a614c9c34d44e0afd2f0c6 Mon Sep 17 00:00:00 2001
From: Oihane Crucelaegui <oihanecruce@gmail.com>
Date: Thu, 27 Jun 2024 14:44:48 +0200
Subject: [PATCH] [IMP] mrp_production_deconstruction: pre-commit stuff

---
 mrp_production_deconstruction/__manifest__.py |   5 +-
 .../models/mrp_bom.py                         |   6 +-
 .../models/mrp_production.py                  |  71 +++++----
 .../models/stock_move_line.py                 |  20 +--
 .../views/mrp_bom_view.xml                    |  20 ++-
 .../views/mrp_production_view.xml             | 141 ++++++++++++++----
 6 files changed, 180 insertions(+), 83 deletions(-)

diff --git a/mrp_production_deconstruction/__manifest__.py b/mrp_production_deconstruction/__manifest__.py
index bfd287a96..0bbce5063 100644
--- a/mrp_production_deconstruction/__manifest__.py
+++ b/mrp_production_deconstruction/__manifest__.py
@@ -2,8 +2,9 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 {
     "name": "MRP Production Deconstruction",
-    'version': '14.0.1.0.0',
+    "version": "14.0.1.0.0",
     "author": "Avanzosc",
+    "website": "https://github.com/avanzosc/mrp-addons",
     "category": "MRP",
     "depends": [
         "mrp",
@@ -13,5 +14,5 @@
         "views/mrp_bom_view.xml",
     ],
     "license": "AGPL-3",
-    'installable': True,
+    "installable": True,
 }
diff --git a/mrp_production_deconstruction/models/mrp_bom.py b/mrp_production_deconstruction/models/mrp_bom.py
index b5ff49fcc..61c710154 100644
--- a/mrp_production_deconstruction/models/mrp_bom.py
+++ b/mrp_production_deconstruction/models/mrp_bom.py
@@ -1,10 +1,12 @@
 # Copyright 2022 Berezi Amubieta - AvanzOSC
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
-from odoo import models, fields
+from odoo import fields, models
 
 
 class MrpBom(models.Model):
     _inherit = "mrp.bom"
 
     is_deconstruction = fields.Boolean(
-        string="Is Deconstruction?", default=False)
+        string="Is Deconstruction?",
+        default=False,
+    )
diff --git a/mrp_production_deconstruction/models/mrp_production.py b/mrp_production_deconstruction/models/mrp_production.py
index 4bfa58eb5..2b0bb4d13 100644
--- a/mrp_production_deconstruction/models/mrp_production.py
+++ b/mrp_production_deconstruction/models/mrp_production.py
@@ -1,6 +1,6 @@
 # Copyright 2022 Berezi Amubieta - AvanzOSC
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
-from odoo import api, models, fields
+from odoo import api, fields, models
 
 
 class MrpProduction(models.Model):
@@ -9,30 +9,33 @@ class MrpProduction(models.Model):
     is_deconstruction = fields.Boolean(
         string="Is Deconstruction?",
         related="bom_id.is_deconstruction",
-        store=True)
+        store=True,
+    )
     move_line_ids = fields.One2many(
         string="Move Lines",
         comodel_name="stock.move.line",
         inverse_name="production_id",
         domain=lambda self: [
-            ("location_dest_id", "in", self.production_location_id.ids)],
-        )
+            ("location_dest_id", "in", self.production_location_id.ids)
+        ],
+    )
     finished_move_line_ids = fields.One2many(
         compute=False,
         inverse_name="production_id",
         domain=lambda self: [
             ("location_id", "in", self.production_location_id.ids),
-            ("location_dest_id", "in", self.location_dest_id.ids)],
-        )
+            ("location_dest_id", "in", self.location_dest_id.ids),
+        ],
+    )
 
-    @api.depends('product_id', 'company_id', "is_deconstruction")
+    @api.depends("product_id", "company_id", "is_deconstruction")
     def _compute_production_location(self):
         super(MrpProduction, self)._compute_production_location()
         for production in self:
             if production.is_deconstruction:
                 production.production_location_id = (
-                    production.picking_type_id.default_location_src_id.id) or (
-                        False)
+                    production.picking_type_id.default_location_src_id.id
+                ) or (False)
 
     def write(self, vals):
         res = super(MrpProduction, self).write(vals)
@@ -46,28 +49,39 @@ def write(self, vals):
 
     def _check_is_deconstruction(self):
         for production in self:
-            if production.bom_id and (
-                production.is_deconstruction) is True and (
-                    production.move_raw_ids):
+            if (
+                production.bom_id
+                and production.is_deconstruction is True
+                and production.move_raw_ids
+            ):
                 origin = production.picking_type_id.default_location_src_id
                 if origin.usage != "internal" and (
-                    production.production_location_id.usage) == (
-                        "internal"):
+                    production.production_location_id.usage == "internal"
+                ):
                     origin = production.production_location_id
                 dest = production.move_raw_ids.location_dest_id
                 if dest.usage == "production":
-                    production.write({
-                        "location_dest_id": dest.id,
-                        "location_src_id": dest.id,
-                        "production_location_id": origin.id})
+                    production.write(
+                        {
+                            "location_dest_id": dest.id,
+                            "location_src_id": dest.id,
+                            "production_location_id": origin.id,
+                        }
+                    )
                     for move in production.move_raw_ids:
-                        move.write({
-                            "location_id": dest.id,
-                            "location_dest_id": origin.id})
-                        for line in move.move_line_ids:
-                            line.write({
+                        move.write(
+                            {
                                 "location_id": dest.id,
-                                "location_dest_id": origin.id})
+                                "location_dest_id": origin.id,
+                            }
+                        )
+                        for line in move.move_line_ids:
+                            line.write(
+                                {
+                                    "location_id": dest.id,
+                                    "location_dest_id": origin.id,
+                                }
+                            )
 
     def action_confirm(self):
         self._check_is_deconstruction()
@@ -79,7 +93,10 @@ def button_mark_done(self):
             if production.is_deconstruction is True:
                 origin = production.finished_move_line_ids.location_id
                 dest = production.finished_move_line_ids.location_dest_id
-                production.finished_move_line_ids.write({
-                    "location_id": dest.id,
-                    "location_dest_id": origin.id})
+                production.finished_move_line_ids.write(
+                    {
+                        "location_id": dest.id,
+                        "location_dest_id": origin.id,
+                    }
+                )
         return result
diff --git a/mrp_production_deconstruction/models/stock_move_line.py b/mrp_production_deconstruction/models/stock_move_line.py
index 2307ae640..998c6e8ad 100644
--- a/mrp_production_deconstruction/models/stock_move_line.py
+++ b/mrp_production_deconstruction/models/stock_move_line.py
@@ -1,6 +1,6 @@
 # Copyright 2022 Berezi Amubieta - AvanzOSC
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
-from odoo import _, api, models, fields
+from odoo import api, fields, models
 
 
 class StockMoveLine(models.Model):
@@ -28,10 +28,8 @@ def _get_default_location_dest_id(self):
                 result = production.picking_type_id.default_location_src_id.id
             return result
 
-    location_id = fields.Many2one(
-        default=_get_default_location_id)
-    location_dest_id = fields.Many2one(
-        default=_get_default_location_dest_id)
+    location_id = fields.Many2one(default=_get_default_location_id)
+    location_dest_id = fields.Many2one(default=_get_default_location_dest_id)
 
     @api.onchange("location_id", "location_dest_id")
     def onchange_product_id_domain(self):
@@ -42,13 +40,9 @@ def onchange_product_id_domain(self):
                 [("id", "=", production)], limit=1
             )
             domain = {}
-            if production.is_deconstruction is not True and (
-                production.move_raw_ids
-            ):
+            if production.is_deconstruction is not True and (production.move_raw_ids):
                 products = production.move_raw_ids.mapped("product_id")
-                domain = {"domain": {"product_id": [
-                    ("id", "in", products.ids)
-                ]}}
+                domain = {"domain": {"product_id": [("id", "in", products.ids)]}}
         elif "default_production_id" in self.env.context:
             production = self.env.context["default_production_id"]
             production = self.env["mrp.production"].search(
@@ -57,7 +51,5 @@ def onchange_product_id_domain(self):
             domain = {}
             if production.move_byproduct_ids:
                 products = production.move_byproduct_ids.mapped("product_id")
-                domain = {"domain": {"product_id": [
-                    ("id", "in", products.ids)
-                ]}}
+                domain = {"domain": {"product_id": [("id", "in", products.ids)]}}
         return domain
diff --git a/mrp_production_deconstruction/views/mrp_bom_view.xml b/mrp_production_deconstruction/views/mrp_bom_view.xml
index 7d66722cc..667bef786 100644
--- a/mrp_production_deconstruction/views/mrp_bom_view.xml
+++ b/mrp_production_deconstruction/views/mrp_bom_view.xml
@@ -1,26 +1,32 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
     <record id="mrp_bom_form_view" model="ir.ui.view">
         <field name="model">mrp.bom</field>
-        <field name="inherit_id" ref="mrp.mrp_bom_form_view"/>
+        <field name="inherit_id" ref="mrp.mrp_bom_form_view" />
         <field name="arch" type="xml">
             <field name="company_id" position="before">
-                <field name="is_deconstruction"/>
+                <field name="is_deconstruction" />
             </field>
             <page name="by_products" position="attributes">
-                <attribute name="attrs">{'invisible': [('is_deconstruction', '=', True)]}</attribute>
+                <attribute
+          name="attrs"
+        >{'invisible': [('is_deconstruction', '=', True)]}</attribute>
             </page>
         </field>
     </record>
 
     <record id="view_mrp_bom_filter" model="ir.ui.view">
         <field name="model">mrp.bom</field>
-        <field name="inherit_id" ref="mrp.view_mrp_bom_filter"/>
+        <field name="inherit_id" ref="mrp.view_mrp_bom_filter" />
         <field name="arch" type="xml">
             <filter name="inactive" position="before">
-                <filter string="Deconstruction" name="is_deconstruction" domain="[('is_deconstruction', '=', True)]"/>
-                <separator/>
+                <filter
+          string="Deconstruction"
+          name="is_deconstruction"
+          domain="[('is_deconstruction', '=', True)]"
+        />
+                <separator />
             </filter>
         </field>
     </record>
diff --git a/mrp_production_deconstruction/views/mrp_production_view.xml b/mrp_production_deconstruction/views/mrp_production_view.xml
index 0b54e91c6..bdf4c8726 100644
--- a/mrp_production_deconstruction/views/mrp_production_view.xml
+++ b/mrp_production_deconstruction/views/mrp_production_view.xml
@@ -1,35 +1,90 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
     <record id="mrp_production_form_view" model="ir.ui.view">
         <field name="model">mrp.production</field>
-        <field name="inherit_id" ref="mrp.mrp_production_form_view"/>
+        <field name="inherit_id" ref="mrp.mrp_production_form_view" />
         <field name="arch" type="xml">
             <field name="company_id" position="after">
-                <field name="is_deconstruction" invisible="1"/>
+                <field name="is_deconstruction" invisible="1" />
             </field>
             <field name="forecast_availability" position="attributes">
-                <attribute name="attrs">{'column_invisible':[('parent.is_deconstruction', '=', True)]}</attribute>
+                <attribute
+          name="attrs"
+        >{'column_invisible':[('parent.is_deconstruction', '=', True)]}</attribute>
             </field>
             <page name="components" position="before">
                 <page name="move_lines" string="Move Lines">
-                    <field name="move_line_ids" context="{'production_id': active_id, 'default_company_id': company_id}" attrs="{'readonly': [('state', 'in', ('draft', 'cancel'))]}">
-                        <tree name="mrp_move_lines" editable="bottom" decoration-muted="state == 'cancel'" string="Move Lines" default_order="location_id" limit="300">
-                            <field name="production_id" invisible="1"/>
-                            <field name="move_id" invisible="1"/>
-                            <field name="tracking" invisible="1"/>
-                            <field name="product_id" context="{'default_type': 'product'}" required="1" attrs="{'readonly': ['|', ('id', '!=', False), ('state', 'in', ('cancel'))]}" options="{'no_create': True}" force_save="1"/>
-                            <field name="lot_id" groups="stock.group_production_lot" attrs="{'readonly': [('tracking', 'not in', ('lot', 'serial'))]}" context="{'default_product_id': product_id, 'default_company_id': company_id}"/>
-                            <field name="location_id" optional="hide" force_save="1"/>
-                            <field name="location_dest_id" optional="hide" force_save="1"/>
-                            <field name="package_id" groups="stock.group_tracking_lot" optional="hide"/>
-                            <field name="result_package_id" groups="stock.group_tracking_lot" optional="hide"/>
-                            <field name="product_uom_category_id" invisible="1"/>
-                            <field name="qty_done"/>
-                            <field name="product_uom_qty" optional="hide" readonly="1" attrs="{'column_invisible':[('parent.is_deconstruction', '=', True)]}" sum="Total Reserved"/>
-                            <field name="product_uom_id" optional="hide" options="{'no_create': True}" groups="uom.group_uom" readonly="1" force_save="1" attrs="{'column_invisible':[('parent.is_deconstruction', '=', True)]}"/>
-                            <field name="company_id" invisible="1" groups="base.group_multi_company" force_save="1"/>
-                            <field name="state" optional="hide"/>
+                    <field
+            name="move_line_ids"
+            context="{'production_id': active_id, 'default_company_id': company_id}"
+            attrs="{'readonly': [('state', 'in', ('draft', 'cancel'))]}"
+          >
+                        <tree
+              name="mrp_move_lines"
+              editable="bottom"
+              decoration-muted="state == 'cancel'"
+              default_order="location_id"
+              limit="300"
+            >
+                            <field name="production_id" invisible="1" />
+                            <field name="move_id" invisible="1" />
+                            <field name="tracking" invisible="1" />
+                            <field
+                name="product_id"
+                context="{'default_type': 'product'}"
+                required="1"
+                attrs="{'readonly': ['|', ('id', '!=', False), ('state', 'in', ('cancel'))]}"
+                options="{'no_create': True}"
+                force_save="1"
+              />
+                            <field
+                name="lot_id"
+                groups="stock.group_production_lot"
+                attrs="{'readonly': [('tracking', 'not in', ('lot', 'serial'))]}"
+                context="{'default_product_id': product_id, 'default_company_id': company_id}"
+              />
+                            <field name="location_id" optional="hide" force_save="1" />
+                            <field
+                name="location_dest_id"
+                optional="hide"
+                force_save="1"
+              />
+                            <field
+                name="package_id"
+                groups="stock.group_tracking_lot"
+                optional="hide"
+              />
+                            <field
+                name="result_package_id"
+                groups="stock.group_tracking_lot"
+                optional="hide"
+              />
+                            <field name="product_uom_category_id" invisible="1" />
+                            <field name="qty_done" />
+                            <field
+                name="product_uom_qty"
+                optional="hide"
+                readonly="1"
+                attrs="{'column_invisible':[('parent.is_deconstruction', '=', True)]}"
+                sum="Total Reserved"
+              />
+                            <field
+                name="product_uom_id"
+                optional="hide"
+                options="{'no_create': True}"
+                groups="uom.group_uom"
+                readonly="1"
+                force_save="1"
+                attrs="{'column_invisible':[('parent.is_deconstruction', '=', True)]}"
+              />
+                            <field
+                name="company_id"
+                invisible="1"
+                groups="base.group_multi_company"
+                force_save="1"
+              />
+                            <field name="state" optional="hide" />
                         </tree>
                     </field>
                 </page>
@@ -39,28 +94,52 @@
 
     <record id="mrp_production_tree_view" model="ir.ui.view">
         <field name="model">mrp.production</field>
-        <field name="inherit_id" ref="mrp.mrp_production_tree_view"/>
+        <field name="inherit_id" ref="mrp.mrp_production_tree_view" />
         <field name="arch" type="xml">
             <field name="activity_exception_decoration" position="after">
-                <field name="is_deconstruction" optional="hide"/>
+                <field name="is_deconstruction" optional="hide" />
             </field>
         </field>
     </record>
 
     <record id="view_mrp_production_filter" model="ir.ui.view">
         <field name="model">mrp.production</field>
-        <field name="inherit_id" ref="mrp.view_mrp_production_filter"/>
+        <field name="inherit_id" ref="mrp.view_mrp_production_filter" />
         <field name="arch" type="xml">
             <filter name="todo" position="before">
-                <filter string="Deconstruction" name="is_deconstruction" domain="[('is_deconstruction', '=', True)]"/>
-                <separator/>
+                <filter
+          string="Deconstruction"
+          name="is_deconstruction"
+          domain="[('is_deconstruction', '=', True)]"
+        />
+                <separator />
             </filter>
             <filter name="filter_date_planned_start" position="after">
-                <filter string="Yesterday" name="yesterday" domain="[('date_planned_start', '&lt;', (context_today()).strftime('%Y-%m-%d')), ('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=2)).strftime('%Y-%m-%d'))]"/>
-                <filter string="Today" name="today" domain="[('date_planned_start', '&lt;', (context_today() + datetime.timedelta(days=1)).strftime('%Y-%m-%d')), ('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=1)).strftime('%Y-%m-%d'))]"/>
-                <filter string="Last Week" name="last_week" domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=7)).strftime('%Y-%m-%d'))]"/>
-                <filter string="Last Month" name="month" domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=30)).strftime('%%Y-%%m-%%d'))]"/>
-                <filter string="Last Year" name="year" domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=365)).strftime('%%Y-%%m-%%d'))]"/>
+                <filter
+          string="Yesterday"
+          name="yesterday"
+          domain="[('date_planned_start', '&lt;', (context_today()).strftime('%Y-%m-%d')), ('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=2)).strftime('%Y-%m-%d'))]"
+        />
+                <filter
+          string="Today"
+          name="today"
+          domain="[('date_planned_start', '&lt;', (context_today() + datetime.timedelta(days=1)).strftime('%Y-%m-%d')), ('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=1)).strftime('%Y-%m-%d'))]"
+        />
+                <filter
+          string="Last Week"
+          name="last_week"
+          domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=7)).strftime('%Y-%m-%d'))]"
+        />
+                <filter
+          string="Last Month"
+          name="month"
+          domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=30)).strftime('%%Y-%%m-%%d'))]"
+        />
+                <filter
+          string="Last Year"
+          name="year"
+          domain="[('date_planned_start','&gt;', (context_today() - datetime.timedelta(days=365)).strftime('%%Y-%%m-%%d'))]"
+        />
             </filter>
         </field>
     </record>