Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: make ignored_modules a tuple of symbols, instead of a tuple of modules #602

Open
charleskawczynski opened this issue Jan 30, 2024 · 1 comment

Comments

@charleskawczynski
Copy link
Contributor

On issue I've run into is that JET will complain about (perhaps deeply nested) indirect dependencies, and that means that one has to add those dependencies to the Project toml in order to ignore those modules. It might be really nice if ignored_modules instead accepted Symbols, so that no additional dependencies are required.

@charleskawczynski
Copy link
Contributor Author

I'm just curious, is there any chance that this issue gets fixed? (cc @aviatesk).

We've been trying to remove CUDA as a direct dependency in some packages, and requiring CUDA just pass this test is a bit unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant