Feature dummy scan #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated methods Signed-off-by: avifenesh <[email protected]>
…ate tests Python binding Signed-off-by: avifenesh <[email protected]>
…de failures Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
Added test cases to verify cluster scan behavior with DELSLOTS command: - test_async_cluster_scan_with_few_delslots: Tests scanning with some slots deleted - test_async_cluster_scan_with_all_delslots: Tests scanning with all slots deleted Signed-off-by: jhpung <[email protected]>
avifenesh
force-pushed
the
Feature-dummyScan
branch
2 times, most recently
from
d9cb45b
to
03b62aa
Compare
avifenesh
reviewed
Nov 29, 2024
| keys.dedup(); | ||
| expected_keys.sort(); | ||
| expected_keys.dedup(); | ||
| assert_eq!(keys, expected_keys); |
There was a problem hiding this comment.
That's may or may not pass, deleting slots means deleting their keys, that's meaning the key you expect may not be there.
avifenesh
reviewed
Nov 29, 2024
| ) | ||
| .await; | ||
|
|
||
| assert!(delslots_res.is_ok()); |
There was a problem hiding this comment.
Should validate that slots are actually missing and there's uncovered slots.
avifenesh
reviewed
Nov 29, 2024
| println!("keys: {:?}", keys); | ||
| expected_keys.sort(); | ||
| expected_keys.dedup(); | ||
| assert_eq!(keys, expected_keys); |
There was a problem hiding this comment.
If you delete all the slots in it worked, the cluster should be empty if im not mistaking, so something is not working here.
avifenesh
force-pushed
the
Feature-dummyScan
branch
2 times, most recently
from
ae43c7f
to
1ba71e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: